Date: Wed, 31 Mar 2010 19:06:48 +0200 From: Bernhard Schmidt <bschmidt@techwires.net> To: Rui Paulo <rpaulo@freebsd.org> Cc: freebsd-net <freebsd-net@freebsd.org>, Antoine Brodin <antoine@FreeBSD.org> Subject: Re: net80211 ratectl proof of concept Message-ID: <20100331170648.GB6121@mx.techwires.net> In-Reply-To: <47F572EE-B5E5-4961-81C5-179AD0F4A90A@freebsd.org> References: <D1EDB040-BB1F-41E2-8E1B-9DEF6171903D@gmail.com> <p2xf19c444a1003310624r68579888jdddb0237d8da4b3f@mail.gmail.com> <63B143BF-20C9-425F-8969-B7452191E84F@freebsd.org> <20100331140415.GB68231@mx.techwires.net> <47F572EE-B5E5-4961-81C5-179AD0F4A90A@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 31, 2010 at 03:05:27PM +0100, Rui Paulo wrote: > On 31 Mar 2010, at 15:04, Bernhard Schmidt wrote: > > > On Wed, Mar 31, 2010 at 02:31:30PM +0100, Rui Paulo wrote: > >> On 31 Mar 2010, at 14:24, Antoine Brodin wrote: > >>> This looks great! > >>> Is there specific reasons to use pointers and not ints for some > >>> arguments of foo_tx_complete() and foo_tx_update()? > >> > >> Not really. I'll probably switch them to ints at some point. > > > > Hmm, I somehow like the idea of not passing integers here. Looking at > > ath_rate/sample it passes a struct. I don't know whether this can be > > rewritten though. > > It can be rewritten to pass ints, from what I understand. Ok great, looks fine to me. Do you intend to commit this in one huge chunk (quite a few drivers affected) or create a branch for that? -- Bernhard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100331170648.GB6121>