Date: Wed, 11 Jun 2008 10:42:50 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.ORG> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: [RFC] patch to AHCI device detection code Message-ID: <E44D5D17-81C7-45DA-8CAB-F41616865F7C@FreeBSD.ORG> In-Reply-To: <484F8609.3090601@yandex.ru> References: <484F7EF9.5080602@yandex.ru> <5291278A-81B5-4665-B5FF-1A6B2EC9CD15@FreeBSD.ORG> <484F8609.3090601@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi You are right on that one of course, from my quick eyeballing the =20 patch I thought you enabled the reset sequence too, but on a closer =20 look its only the extra timeout, my bad. However, the most usual problem is that the devices does not leave a =20 signature behind due to the missing reset sequence. That problem is =20 50/50 as some controllers apparently doesn't like the resetting and =20 will leave busy set and a hanging channel. I'll be getting some new HW here in the lab tomorrow if all goes well, =20= that will let me play with this on one of the failing devices again. =20 Maybe I'll find a generic solution this time around. I'll commit this patch for now, as you said, it doesn't hurt.. -S=F8ren On 11Jun, 2008, at 10:00 , Andrey V. Elsukov wrote: > S=F8ren Schmidt wrote: >> Well, as you can see I tried this when I added the PM code to AHCI, =20= >> however one of the reasons I left it out again (for now) is that it =20= >> doesn't work on more than about 50% of the AHCI chipsets out there.. >> Modern HW in a nutshell, you win some you loose some ;) > > Hm.. I think it can't made regression. I don't see nothing dangerous > in addition 1s waiting (it doesn't enable softreset code, only PxTFD > reading loop).. > > --=20 > WBR, Andrey V. Elsukov >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E44D5D17-81C7-45DA-8CAB-F41616865F7C>