Date: Thu, 04 Sep 2008 00:16:31 +0400 From: Sergey Matveychuk <sem@FreeBSD.org> To: Naram Qashat <cyberbotx@cyberbotx.com> Cc: ports@freebsd.org Subject: Re: portupgrade fails with quoted options Message-ID: <48BEF09F.6030604@FreeBSD.org> In-Reply-To: <48BEAC6B.7000307@cyberbotx.com> References: <48BC2A79.1080905@cyberbotx.com> <48BD1527.4000500@FreeBSD.org> <48BD1F33.10204@cyberbotx.com> <48BD30A5.6020601@FreeBSD.org> <48BDFFB1.9080408@cyberbotx.com> <48BE810F.9070206@FreeBSD.org> <48BEAC6B.7000307@cyberbotx.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Naram Qashat wrote: > Sergey Matveychuk wrote: >> Naram Qashat wrote: >>> Sergey Matveychuk wrote: >>>> Naram Qashat wrote: >>>>>>> Notice how WITH_MODULES has quotes around it and then escaped >>>>>>> quotes inside it? It shouldn't be doing things like that. I >>>>>>> don't know ruby (I only made that above script from looking at >>>>>>> some parts of portupgrade, but I have almost no understanding of >>>>>>> ruby), so I can't give a fix for this. >>>> >>>> Try the patch please. (cd /usr/local/lib/ruby/site_ruby/1.8; patch < >>>> ~/pkgmisc.rb.diff) >>>> Does it fix the problem for you? >>>> >>> >>> It seems like it got a little farther, but it still bombed. I'm not >>> sure if the new problems is a problems in portupgrade's ruby scripts >>> or if it's something in the Makefiles themselves: >>> >>> ---> Reinstalling 'apache-2.2.9_3' (www/apache22) >>> ---> Building '/usr/ports/www/apache22' with make flags: BATCH=yes >>> WITH_OPENSSL_PORT=yes WITH_OPENSSL=yes WITHOUT_GNOME=esound >>> WITHOUT_CUPS=yes WITH_BDB_VER=46 WITH_MYSQL_VER=50 >>> WITH_OPTIMIZED_CFLAGS=yes WITHOUT_APACHE_OPTIONS=yes >>> WITH_PCRE_FROM_PORTS=yes WITH_MYSQL=yes WITH_BDB=yes WITH_SUEXEC=yes >>> SUEXEC_LOGFILE=/var/log/www/httpd-suexec.log WITH_MODULES="actions >>> alias auth_basic auth_digest authn_dbd authn_default authz_default >>> authz_host authz_user autoindex cgi dav dav_fs dav_lock dbd deflate >>> dir echo env expires filter headers ident imagemap include info >>> log_config log_forensic logio mime mime_magic negotiation rewrite >>> setenvif status suexec unique_id userdir version vhost_alias" >>> "/usr/ports/Mk/bsd.apache.mk", line 261: Need an operator >>> ** Listing the failed packages (-:ignored / *:skipped / !:failed) >>> ! www/apache22 (apache-2.2.9_3) (clean error) >>> >>> But that does seem to be a step in a right direction. >>> >>> Naram Qashat >> >> Quotas still there! >> Can you open file /usr/local/lib/ruby/site_ruby/1.8/pkgmisc.rb and add >> after line 96: arg.gsub(/([$\\\`])/, "\\\\\\1") the line: >> arg.gsub(/\"/, "") >> ? >> >> It should fix the error. >> Looks like it's a long standing bug from a knu@ era :) >> If it's OK for you, I'll add the patch to a portupgrade port. > > That doesn't fix it. I would suspect it would make it worse because it > would treat all the options after the first one in WITH_MODULES as if > they were passed to make directly instead of via a knob. It still gives Are you complete sure in it? My tests shows the knob passed as one argument in command line. > the same error from bsd.apache.mk though. OK. So I need more free time to check it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48BEF09F.6030604>