Date: Wed, 15 Apr 2009 12:30:05 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-acpi@freebsd.org Subject: Re: run resume code only for S1-S4 states Message-ID: <200904151230.06288.jkim@FreeBSD.org> In-Reply-To: <49E60731.8050402@freebsd.org> References: <49DB639A.4090504@icyb.net.ua> <200904151208.03822.jkim@FreeBSD.org> <49E60731.8050402@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 15 April 2009 12:11 pm, Andriy Gapon wrote: > on 15/04/2009 19:08 Jung-uk Kim said the following: > > Actually, my patch was more complex, e.g., I added more code to > > make sure power/sleep button events get ignored and cleared when > > it is not in S0 state, etc. Probably I needed to track the > > current state because of it. I think you may ignore it for now > > if it is not needed anywhere else. > > Interesting. I think that I will go with the current patch (modulo > break->goto changes), if my mentors approve. But I would like to > see your patch :-) I am not sure I still have it. It wasn't finished (thus not committed) because it was a lot more complex than I originally thought. We really have to consolidate ACPI state tracking in one variable outside of ACPI softc so that it can be atomically tracked without complex locking/unlocking layers of various locks, e.g., acpi_button from DSDT, fixed buttons from FADT, acpi, giant, etc. :-( Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904151230.06288.jkim>