Date: Thu, 04 Jun 2009 10:06:52 +0400 From: Boris Samorodov <bsam@ipt.ru> To: glarkin@FreeBSD.org Cc: emulation@FreeBSD.org Subject: Re: Fix for CONFLICTS in emulators/linux_base ports Message-ID: <01209091@bb.ipt.ru> In-Reply-To: <4A26BB95.7010002@FreeBSD.org> (Greg Larkin's message of "Wed\, 03 Jun 2009 14\:06\:13 -0400") References: <4A242BF1.9050202@FreeBSD.org> <22672149@h30.sp.ipt.ru> <4A26BB95.7010002@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 03 Jun 2009 14:06:13 -0400 Greg Larkin wrote: > Boris Samorodov wrote: > > (Seems I've got this mail by private email and send an answer. > > but for archieves I'll duplicate it here.) > > > > On Mon, 01 Jun 2009 15:28:49 -0400 Greg Larkin wrote: > > > >> Hi emulation team, > > > >> I'm working on a PR for graphics/linux-ac3d, and it required me to > >> upgrade my linux_base-fc-4_14 package. I noticed that the newer > >> linux_base-f ports don't include the correct package name in CONFLICTS > >> for the older port. > > > > Thanks for taking care of it. I should have done it myself but > > you know there are always other first-aid-things to do... :-( > > > >> I have included a patch for the ports that you maintain. Please review > >> it when you have a moment and let me know what you think. > > > >> http://people.freebsd.org/~glarkin/diffs/bsam-linux_base.diff > > > > Some thoughts: > > . I'm not sure if names without * can match anything (and > > anyway if they do, ex. linux_base-fc will match linux_base-fc6, > > the third diff); > > . there are more linux_base ports now (including linux_base-f9, > > linux_base-f10). They should be included into CONFLICTS and > > their CONFLICTS should be considered either. > Hi Boris, > I sent two emails with two separate patches, one directly to you and one > to emulation@, since I wasn't sure who is a member of that alias. Sorry > for the confusion on my end. No problem. > Perhaps there is a very simple solution - do you think that all > linux_base ports should have the following CONFLICTS line? > CONFLICTS= linux_base-* > That way, all Linux emulation layers will conflict with every other one, > and we'll be covered for any future revisions. Did you try it yourself? ;-) That way every linux base port will conflict with itself! > Let me know what you think, and I can commit the changes after > generating a new patch for your review, if you like. WBR -- Boris Samorodov (bsam) Research Engineer, http://www.ipt.ru Telephone & Internet SP FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01209091>