Date: Fri, 12 Jun 2009 17:49:12 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: Pyun YongHyeon <pyunyh@gmail.com>, FreeBSD net mailing list <freebsd-net@FreeBSD.org>, "George V. Neville-Neil" <gnn@FreeBSD.org>, Michael Tuexen <tuexen@FreeBSD.org>, Navdeep Parhar <np@FreeBSD.org>, Andrew Thompson <thompsa@FreeBSD.org>, Jack F Vogel <jfv@FreeBSD.org>, Andrew Gallatin <gallatin@FreeBSD.org>, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: Ethernet NIC drivers depending unconditionally on INET Message-ID: <20090612174706.N22887@maildrop.int.zabbadoz.net> In-Reply-To: <4A3293C8.5070101@cs.duke.edu> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <20090612170703.GA994@hub.freebsd.org> <20090612173728.B22887@maildrop.int.zabbadoz.net> <4A3293C8.5070101@cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Jun 2009, Andrew Gallatin wrote: > Bjoern A. Zeeb wrote: >> On Fri, 12 Jun 2009, Navdeep Parhar wrote: >> >>> On Fri, Jun 12, 2009 at 10:56:31AM +0000, Bjoern A. Zeeb wrote: >>>> On Fri, 12 Jun 2009, Pyun YongHyeon wrote: >>>> >>>> Hi, >>>> >>>>> Yeah, there are no checksum offloading support for IPv6 under >>>>> FreeBSD so there are no cases the frames are IPv6 when >>>>> CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. >>>> >>>> The thing that scared me was sys/netinet/tcp_subr.c:tcp_maxmtu6(). >>>> >>>> What I had missed was the CSUM_TSO6 (the 6 at the end) part. >>>> grepping through the tree I am even wondering a lot more now when I >>>> see what cxgb(4) is doing with that;) >>> >>> I can't find a CSUM_TSO6 in head, did you mean IFCAP_TSO6? >> >> yes I did. >> >>> cxgb(4) >>> will not let you enable IFCAP_TSO6 on the interface. It has always >>> been disallowed as far as I can tell. >> >> Yes, you have it in the logic bu you define it to 0;) >> #define IFCAP_TSO6 0x0 > > So I guess TSO6 has never been tested at all on any interface on > Freebsd. Is this true? I wan't not sure; looking at em_tso_setup() in sys/dev/e1000/if_em.c, there was v6 code as well; the I spotted the return FALSE; So I guess, you are right; noone ever did TSO6 on FreeBSD probably. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090612174706.N22887>