Date: Tue, 14 Jul 2009 12:03:17 +0100 From: Matthew Seaman <m.seaman@infracaninophile.co.uk> To: Cezary Morga <cm@therek.net> Cc: QAT@freebsd.org, freebsd ports <freebsd-ports@freebsd.org> Subject: Re: [Custom LOCALBASE/PREFIX] www/p5-RT-Extension-SLA - fails: mtree Message-ID: <4A5C65F5.6020704@infracaninophile.co.uk> In-Reply-To: <4A5C5F55.4090204@therek.net> References: <20090706181739.D2DB28FCB7@release.ixsystems.com> <4A5363AA.8030407@infracaninophile.co.uk> <4A5B97D7.2070708@therek.net> <4A5C4E73.9000901@infracaninophile.co.uk> <4A5C5F55.4090204@therek.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig1D54128B30138CD017AADD40
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: quoted-printable
Cezary Morga wrote:
> Matthew Seaman pisze:
>> I think that your patch essentially does that, but see ports/136656 wh=
ere
>> I have a simpler solution -- just remove $PREFIX from the environment
>> during configuration.
>=20
> I don't think removing PREFIX is a good idea. FreeBSD is supposed to=20
> support PREFIX for users wishing to install ports elsewhere than=20
> /usr/local, that's what this QAT tests 'Custom LOCALBASE/PREFIX' are ab=
out.
That is not the effect of my patch at all.
You are failing to distinguish between $PREFIX set as an environment vari=
able
and $PREFIX the make variable. PREFIX the make variable already controls=
what
the p5-RT-Extension ports do as variables like SITE_PERL are defined in
terms of it already. As I said in an earlier post: these ports already =
honour
PREFIX correctly when it is defined eg. in /etc/make.conf. (The same appl=
ies to
LOCALBASE for that matter, but LOCALBASE means nothing to perl configure =
scripts,
so this whole question doesn't arise)
In fact, it's the make variable which is the important thing for the port=
s, and
the confusion here arises because different Makefiles or scripts are re-i=
mporting
the value from the environment instead of inheriting the settings from
superior makes.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard
Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate
Kent, CT11 9PW
--------------enig1D54128B30138CD017AADD40
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEAREIAAYFAkpcZfsACgkQ8Mjk52CukIz2xACfeDVKIm2WHqWGF0TlC00rwIQ9
HNYAn1+gLZ1/r9ReprCnEfYerSXt99oD
=dDif
-----END PGP SIGNATURE-----
--------------enig1D54128B30138CD017AADD40--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A5C65F5.6020704>