Date: Mon, 28 Sep 2009 12:32:52 -0400 From: Naram Qashat <cyberbotx@cyberbotx.com> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: fontforge: bug in configure? Message-ID: <4AC0E534.6010405@cyberbotx.com> In-Reply-To: <4AC0C565.50106@icyb.net.ua> References: <4AC0C565.50106@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Andriy Gapon wrote: > It seems that there is a subtle bug in fontforge's configure: > > CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O2// | sed -e s/-O//` > > This is supposed to produce CFLAGS with all optimization options stripped. > Let's leave alone the fact that there could be -O1 flag or -O3 or even > -funroll-all-loops. > Still, 'g' option is missing from the sed commands. > Say, CFLAGS contain "-O2 ... -O2", then the first sed command would strip only the > first occurrence of -O2 and the second command would leave a dangling '2'. > This is what I am hitting here. > > Proposal: > CFLAGS_NOOPT=`echo $CFLAGS | sed -e s/-O[0-9]*//g` > > What do you think? I'd be fine with that. I'll submit a PR for it later today. Thanks, Naram Qashat
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AC0E534.6010405>