Date: Thu, 31 Dec 2009 18:35:28 -0500 From: Glen Barber <glen.j.barber@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: ports@freebsd.org, "Philip M. Gollucci" <pgollucci@p6m7g8.com> Subject: Re: cvs commit: ports/mail/p5-qpsmtpd/files qpsmtpd.in Message-ID: <4ad871310912311535g2de5465od60548fca0aa2123@mail.gmail.com> In-Reply-To: <4B3D2606.4040605@FreeBSD.org> References: <200912100507.nBA577Q3033700@repoman.freebsd.org> <4B2330FB.70309@FreeBSD.org> <4B243FBC.8080507@p6m7g8.com> <4B26A861.2080805@FreeBSD.org> <4ad871310912141329r540d5cd9of33ec2963dbf999d@mail.gmail.com> <4ad871310912311115g5c821d0bhd5d6c03f167deef1@mail.gmail.com> <4B3D2606.4040605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015174481dacee840047c0eb51b Content-Type: text/plain; charset=ISO-8859-1 Hi Doug, I really appreciate the feedback. On Thu, Dec 31, 2009 at 5:30 PM, Doug Barton <dougb@freebsd.org> wrote: > Glen Barber wrote: [...] > > I've attached a diff for a script that works, please test it and if > you're satisfied I will commit it for you. However, there is > apparently an additional problem with the port because when I > installed it the "smtpd" user was not created. If that is mandatory > for the script to work it should be added by the port. I could get it > started if I specified another unprivileged user/group in rc.conf.local. > Initially, they were the user/group I was using to run this service. I later found it was not necessary, and in changing the rc script, I had forgotten to remove them. This service runs fine with nobody/nogroup, which is reflected in an attached patch, which incorporates your changes. [...] > 11. Properly sets the defaults for the options. (FYI, in your patch > you used: ': foo="bar"', spend a few minutes thinking about why that's > bad.) :) I'm glad embarrassment doesn't translate well over the internet... :-) A diff against the port version with your modifications and my nobody/nogroup changes is attached. If it is okay with the maintainer (cc'd), I think this can be committed. Thanks again for the feedback, and I really appreciate your explanations. Regards, -- Glen Barber --0015174481dacee840047c0eb51b Content-Type: text/plain; charset=US-ASCII; name="qpsmtpd.3.txt" Content-Disposition: attachment; filename="qpsmtpd.3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g3w66m3h1 ZGlmZiAtcnVOIC91c3IvcG9ydHMvbWFpbC9wNS1xcHNtdHBkL01ha2VmaWxlIC91c3IvbG9jYWwv cG9ydHMvbWFpbC9wNS1xcHNtdHBkL01ha2VmaWxlCi0tLSAvdXNyL3BvcnRzL21haWwvcDUtcXBz bXRwZC9NYWtlZmlsZQkyMDA5LTEyLTI2IDE3OjIwOjM1LjAwMDAwMDAwMCAtMDUwMAorKysgL3Vz ci9sb2NhbC9wb3J0cy9tYWlsL3A1LXFwc210cGQvTWFrZWZpbGUJMjAwOS0xMi0zMSAxNzo1OTox NC4wMDAwMDAwMDAgLTA1MDAKQEAgLTM2LDYgKzM2LDcgQEAKIAogVVNFX1JDX1NVQlI9CXFwc210 cGQKIAorU1VCX0xJU1QrPQlQRVJMPSR7UEVSTH0KIFNVQl9MSVNUKz0JUE9SVE5BTUU9JHtQT1JU TkFNRX0KIFNVQl9GSUxFUys9CXBrZy1tZXNzYWdlCiAKZGlmZiAtcnVOIC91c3IvcG9ydHMvbWFp bC9wNS1xcHNtdHBkL2ZpbGVzL3Fwc210cGQuaW4gL3Vzci9sb2NhbC9wb3J0cy9tYWlsL3A1LXFw c210cGQvZmlsZXMvcXBzbXRwZC5pbgotLS0gL3Vzci9wb3J0cy9tYWlsL3A1LXFwc210cGQvZmls ZXMvcXBzbXRwZC5pbgkyMDA5LTEyLTEwIDAwOjA3OjA3LjAwMDAwMDAwMCAtMDUwMAorKysgL3Vz ci9sb2NhbC9wb3J0cy9tYWlsL3A1LXFwc210cGQvZmlsZXMvcXBzbXRwZC5pbgkyMDA5LTEyLTMx IDE4OjEzOjE0LjAwMDAwMDAwMCAtMDUwMApAQCAtMSwxMDAgKzEsNTYgQEAKICMhL2Jpbi9zaAog CisjICRGcmVlQlNEJAorIwogIyBQUk9WSURFOiBxcHNtdHBkCi0jIFJFUVVJUkU6IE5FVFdPUktJ TkcgU0VSVkVSUwotIyBCRUZPUkU6IHNlY3VyZWxldmVsCisjIFJFUVVJUkU6IExPR0lOCisjIEtF WVdPUkQ6IHNodXRkb3duCisjCisjIEFkZCB0aGUgZm9sbG93aW5nIGxpbmVzIHRvIC9ldGMvcmMu Y29uZi5sb2NhbCBvciAvZXRjL3JjLmNvbmYKKyMgdG8gZW5hYmxlIHRoaXMgc2VydmljZToKKyMK KyMgcXBzbXRwZF9lbmFibGUgKGJvb2wpOglTZXQgdG8gTk8gYnkgZGVmYXVsdAorIwkJU2V0IGl0 IHRvIFlFUyB0byBlbmFibGUgcXBzbXRwZAorIyBxcHNtdHBkX3VzZXIgKHN0cmluZyk6CVNldCB0 byAibm9ib2R5IiBieSBkZWZhdWx0CisjCQlUaGUgdXNlciB0byBydW4gcXBzbXRwZC1mb3Jrc2Vy dmVyIGFzCisjIHFwc210cGRfZ3JvdXAgKHN0cmluZyk6CVNldCB0byAibm9ncm91cCIgYnkgZGVm YXVsdAorIwkJVGhlIGdyb3VwIHRoZSBwaWQgZGlyIHdpbGwgYmUgY2hvd25lZCB0bworIyBxcHNt dHBkX3BvcnQgKGludCk6CQlTZXQgdG8gMjUyNSBieSBkZWZhdWx0CisjCQlUaGUgcG9ydCBpdCBz aG91bGQgbGlzdGVuIG9uCisjIHFwc210cGRfbWF4X3Blcl9pcCAoaW50KToJU2V0IHRvIDMgYnkg ZGVmYXVsdAorIwkJTWF4IGNvbm5lY3Rpb25zIHBlciBJUAorIyBxcHNtdHBkX21heF9jb25uZWN0 aW9ucyAoaW50KTogU2V0IHRvIDE1IGJ5IGRlZmF1bHQKKyMJCU1heGltdW0gdG90YWwgY29ubmVj dGlvbnMKKyMgcXBzbXRwZF9saXN0ZW5fb24gKGFkZHJlc3MpOglTZXQgdG8gMC4wLjAuMCBieSBk ZWZhdWx0CisjIAkJSVAgYWRkcmVzcyB0byBsaXN0ZW4gb24KIAotI3ZhcmlhYmxlcwotI3Fwc210 cGRfdXNlciA9IHRoZSB1c2VyIHRvIHJ1biBxcHNtdHBkLWZvcmtzZXJ2ZXIgdW5kZXIKLSNxcHNt dHBkX2dyb3VwID0gdGhlIGdyb3VwIHRoZSBwaWQgZGlyIHdpbGwgYmUgY2hvd25lZCB0bwotI3Fw c210cGRfcG9ydCA9IHRoZSBwb3J0IGl0IHNob3VsZCBsaXN0ZW4gb24KLSNxcHNtdHBkX21heF9w ZXJfaXAgPSBtYXggY29ubmVjdGlvbnMgcGVyIElQCi0jcXBzbXRwZF9tYXhfY29ubmVjdGlvbnMg PSBtYXhpbXVtIHRvdGFsIGNvbm5lY3Rpb25zCi0jcXBzbXRwZF9saXN0ZW5fb24gPSBJUCB0byBs aXN0ZW4gb24KLQotLiAiL2V0Yy9yYy5zdWJyIgorLiAvZXRjL3JjLnN1YnIKIAogbmFtZT0icXBz bXRwZCIKIHJjdmFyPWBzZXRfcmN2YXJgCi1sb2FkX3JjX2NvbmZpZyAkbmFtZQogCiBjb21tYW5k PSIlJVBSRUZJWCUlL2Jpbi9xcHNtdHBkLWZvcmtzZXJ2ZXIiCitjb21tYW5kX2ludGVycHJldGVy PSUlUEVSTCUlCiBwaWRmaWxlPSIvdmFyL3J1bi9xcHNtdHBkL3Fwc210cGQucGlkIgogCi1zdGFy dF9wcmVjbWQ9InN0YXJ0X3ByZWNtZCIKLXN0YXJ0X2NtZD0ic3RhcnRfY21kIgotc3RvcF9jbWQ9 InN0b3BfY21kIgorc3RhcnRfcHJlY21kPSR7bmFtZX1fcHJlc3RhcnQKIAotc3RhcnRfcHJlY21k KCkKK3Fwc210cGRfcHJlc3RhcnQoKQogewotICAgICNleGl0cyBpZiBubyB1c2VyIGlzIHNwZWNp ZmllZAotICAgIGlmIFsgLXogJHFwc210cGRfdXNlciBdOyB0aGVuCi0JZWNobyAicXBzbXRwZF91 c2VyIG5vdCBzZXQiCi0JZXhpdCAxCi0gICAgZmkKLQotICAgICNleGl0cyBpZiBubyBncm91cCBp cyBzcGVjaWZpZWQKLSAgICBpZiBbIC16ICRxcHNtdHBkX2dyb3VwIF07IHRoZW4KLQllY2hvICJx cHNtdHBkX2dyb3VwIG5vdCBzZXQiCi0JZXhpdCAxCi0gICAgZmkKLQotICAgICNzZXRzIGl0IHRv IHRoZSBkZWZhdWx0IGlmIHRoZSBwb3J0IGlzIG5vdCBzcGVjaWZpZWQKLSAgICBpZiBbIC16ICRx cHNtdHBkX3BvcnQgXTsgdGhlbgotCXFwc210cGRfcG9ydD0iMjUyNSIKLSAgICBmaQotICAgIAot ICAgICNzZXQgaXQgdG8gdGhlIGRlZmF1bHQgbWF4IHBlciBpcAotICAgIGlmIFsgLXogJHFwc210 cGRfbWF4X3Blcl9pcCBdOyB0aGVuCi0JcXBzbXRwZF9tYXhfcGVyX2lwPSI1IgotICAgIGZpCi0g ICAgCi0gICAgI3NldCBpdCBkbyB0aGUgbWF4IG51bWJlciBvZiBjb25uZWN0aW9ucyB0b3RhbAot ICAgIGlmIFsgLXogJHFwc210cGRfbWF4X2Nvbm5lY3Rpb25zIF07IHRoZW4KLQlxcHNtdHBkX21h eF9jb25uZWN0aW9ucz0iMTUiCi0gICAgZmkKLSAgICAKLSAgICAjc2V0IHRoZSBkZWZhdWx0IGxp c3RlbiBvbiB0byBldmVyeXRoaW5nCi0gICAgaWYgWyAteiAkcXBzbXRwZF9saXN0ZW5fb24gXTsg dGhlbgotCXFwc210cGRfbGlzdGVuX29uPSIwLjAuMC4wIgotICAgIGZpCi0KLSAgICBpZiBbICEg LWQgL3Zhci9ydW4vcXBzbXRwZC8gXSA7IHRoZW4KLQlta2RpciAvdmFyL3J1bi9xcHNtdHBkCi0g ICAgZmkKLSAgICAKLSAgICBjaG93biAkcXBzbXRwZF91c2VyOiRxcHNtdHBkX2dyb3VwIC92YXIv cnVuL3Fwc210cGQgICAgCisJWyAtZCAvdmFyL3J1bi9xcHNtdHBkIF0gfHwgbWtkaXIgL3Zhci9y dW4vcXBzbXRwZAorCWNob3duICRxcHNtdHBkX3VzZXI6JHFwc210cGRfZ3JvdXAgL3Zhci9ydW4v cXBzbXRwZAogfQogCi1zdGFydF9jbWQoKQotewotCWlmIFsgLWUgJHBpZGZpbGUgXTsgdGhlbgot CQllY2hvICIkbmFtZSBhbHJlYWR5IHJ1bm5pbmcgYXMgUElEIGBjYXQgJHBpZGZpbGVgLiIKLQkJ ZXhpdCAxCi0JZWxzZQotCQlldmFsICRjb21tYW5kIFwKLQkJLXAgJHFwc210cGRfcG9ydCBcCi0J CS1jICRxcHNtdHBkX21heF9jb25uZWN0aW9ucyBcCi0JCS11ICRxcHNtdHBkX3VzZXIgXAotCQkt bSAkcXBzbXRwZF9tYXhfcGVyX2lwIFwKLQkJLWwgJHFwc210cGRfbGlzdGVuX29uIFwKLQkJLS1w aWQtZmlsZSAkcGlkZmlsZSBcCi0JCS1kIFwKLQkJJiYgZWNobyAiJG5hbWUgc3RhcnRlZCBhcyBQ SUQgYGNhdCAkcGlkZmlsZWAuIiBcCi0JCXx8IGVjaG8gIkZhaWxlZCB0byBzdGFydCAkbmFtZSIK LQlmaQotfQorbG9hZF9yY19jb25maWcgJG5hbWUKIAotc3RvcF9jbWQoKQotewotCWlmIFsgLWUg JHBpZGZpbGUgXTsgdGhlbgotCQlraWxsIGBjYXQgJHBpZGZpbGVgIFwKLQkJJiYgZWNobyAiJG5h bWUgc3RvcHBlZC4iIFwKLQkJfHwgZWNobyAiQ291bGQgbm90IHN0b3AgYGNhdCAkcGlkZmlsZWAu IgotCWVsc2UKLQkJZWNobyAiQ2Fubm90IGZpbmQgJHBpZGZpbGUgLSAkbmFtZSBub3QgcnVubmlu Zz8iCi0JCWV4aXQgMQotCWZpCi19Cis6ICR7cXBzbXRwZF9lbmFibGU9Ik5PIn0KKzogJHtxcHNt dHBkX3VzZXI9Im5vYm9keSJ9Cis6ICR7cXBzbXRwZF9ncm91cD0ibm9ncm91cCJ9Cis6ICR7cXBz bXRwZF9wb3J0PSIyNTI1In0KKzogJHtxcHNtdHBkX21heF9wZXJfaXA9IjMifQorOiAke3Fwc210 cGRfbWF4X2Nvbm5lY3Rpb25zPSIxNSJ9Cis6ICR7cXBzbXRwZF9saXN0ZW5fb249IjAuMC4wLjAi fQorCitjb21tYW5kX2FyZ3M9Ii1kIC1wICRxcHNtdHBkX3BvcnQgLWMgJHFwc210cGRfbWF4X2Nv bm5lY3Rpb25zIC11ICRxcHNtdHBkX3VzZXIgLW0gJHFwc210cGRfbWF4X3Blcl9pcCAtbCAkcXBz bXRwZF9saXN0ZW5fb24gLS1waWQtZmlsZSAkcGlkZmlsZSIKIAogcnVuX3JjX2NvbW1hbmQgIiQx Igo= --0015174481dacee840047c0eb51b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ad871310912311535g2de5465od60548fca0aa2123>