Date: Sun, 24 Jan 2010 13:37:18 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Gabor Kovesdan <gabor@freebsd.org> Cc: attilio@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, Peter Jeremy <peterjeremy@acm.org>, current@freebsd.org Subject: Re: NLS/strerror efficiency Message-ID: <20100124113718.GC3877@deviant.kiev.zoral.com.ua> In-Reply-To: <4B5C27B9.1080805@FreeBSD.org> References: <20100119212019.GL59590@deviant.kiev.zoral.com.ua> <4B56CACF.50508@FreeBSD.org> <yge1vhgvdd3.wl%ume@mahoroba.org> <4B5B4F4B.3030201@FreeBSD.org> <20100124091911.GI31243@server.vk2pj.dyndns.org> <4B5C27B9.1080805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 24, 2010 at 11:58:01AM +0100, Gabor Kovesdan wrote: > El 2010. 01. 24. 10:19, Peter Jeremy escribi?: > >I think this is a good start but still needs some work. One issue is > >that the patch mixes whitespace changes (some not complying with > >style(9)) and functional changes. This makes it harder to see the > >functional changes. > > =20 > I thought fixing up some style(9) nits was ok but I meant them to be=20 > compliant with style(9). Could you please point out, which are not=20 > compliant? Shall I revert the style(9) changes for now? > >How much of an issue is this in reality? There are two cases to > >consider: > >1) A process that dynamically changes its locale. > >2) Locale files being updated whilst the process is running. > > > >The first can be worked around by also caching the current locale > >and checking that it hasn't changed. > > =20 > I'll fix up my patch to do that. > >The second is more problematic - particularly for long-running > >programs. Maybe add a timestamp and re-check every minute or 5. > > =20 > I agree, that it should track changing catalogs but do we really want=20 > that? Catalogs are usually bundled with third-party apps and if you=20 > update something you obviously want to restart that. And in the case of= =20 > strerror(3), catalogs are supposed to be updated with libc and when you= =20 > update libc you probably want to restart everything. I do not think that this ought to be handled. Dynamic locale change, on the other hand, is something I have actually seen. --w7PDEPdKQumQfZlR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAktcMO0ACgkQC3+MBN1Mb4gt8QCeMbX51g0RDUOWduLTJv990M9z AckAoIFckJbaGZ+233pTd/STtcUGCepu =WGGN -----END PGP SIGNATURE----- --w7PDEPdKQumQfZlR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100124113718.GC3877>