Date: Sun, 15 Aug 2010 18:13:43 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Andre Oppermann" <andre@freebsd.org>, <freebsd-net@freebsd.org> Subject: Re: TCP inflight limiter disabled and scheduled for removal Message-ID: <A4AD3D12923E4CE79A89000A81E180BE@multiplay.co.uk> References: <4C67EBCC.7000507@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Will be glad to see this go, only ever caused performance issues here :(
Regards
Steve
----- Original Message -----
From: "Andre Oppermann" <andre@freebsd.org>
To: <freebsd-net@freebsd.org>
Sent: Sunday, August 15, 2010 2:29 PM
Subject: TCP inflight limiter disabled and scheduled for removal
> FYI the TCP inflight limiter is now disabled by default and will be
> removed soon. It was interfering with the congestion control algorithms
> and the upcoming pluggable congestion control framework allows other
> approaches to be selected at runtime.
>
> -------- Original Message --------
> Subject: svn commit: r211315 - head/sys/netinet
> Date: Sat, 14 Aug 2010 20:40:55 +0000 (UTC)
> From: Andre Oppermann <andre@FreeBSD.org>
> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
>
> Author: andre
> Date: Sat Aug 14 20:40:55 2010
> New Revision: 211315
> URL: http://svn.freebsd.org/changeset/base/211315
>
> Log:
> Disable TCP inflight limiter by default.
>
> It was experimental and interferes with the normal congestion control
> algorithms by instating a separate, possibly lower, ceiling for the
> amount of data that is in flight to the remote host. With high speed
> internet connections the inflight limit frequently has been estimated
> too low due to the noisy nature of the RTT measurements.
>
> This code gives way for the upcoming pluggable congestion control
> framework. It is the task of the congestion control algorithm to
> set the congestion window and amount of inflight data without external
> interference.
>
> Reviewed by: lstewart
> MFC after: 1 week
> Removal after: 1 month
>
> Modified:
> head/sys/netinet/tcp_subr.c
>
> Modified: head/sys/netinet/tcp_subr.c
> ==============================================================================
> --- head/sys/netinet/tcp_subr.c Sat Aug 14 20:12:10 2010 (r211314)
> +++ head/sys/netinet/tcp_subr.c Sat Aug 14 20:40:55 2010 (r211315)
> @@ -221,7 +221,7 @@ SYSCTL_VNET_INT(_net_inet_tcp, OID_AUTO,
> SYSCTL_NODE(_net_inet_tcp, OID_AUTO, inflight, CTLFLAG_RW, 0,
> "TCP inflight data limiting");
>
> -static VNET_DEFINE(int, tcp_inflight_enable) = 1;
> +static VNET_DEFINE(int, tcp_inflight_enable) = 0;
> #define V_tcp_inflight_enable VNET(tcp_inflight_enable)
> SYSCTL_VNET_INT(_net_inet_tcp_inflight, OID_AUTO, enable, CTLFLAG_RW,
> &VNET_NAME(tcp_inflight_enable), 0,
>
>
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
>
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A4AD3D12923E4CE79A89000A81E180BE>