Date: Sun, 29 Aug 2010 12:22:20 -0400 From: Joe Marcus Clarke <marcus@freebsd.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: gnome@freebsd.org Subject: Re: ports/149134: x11/gnome2 unable to unmount UFS file system Message-ID: <4C7A893C.2070000@freebsd.org> In-Reply-To: <4C7A2885.9000306@icyb.net.ua> References: <20100827001412.C8B381CC3A@ptavv.es.net> <4C79635A.7030101@freebsd.org> <4C796B4E.8020704@icyb.net.ua> <4C798B36.3040300@freebsd.org> <4C7A2885.9000306@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/29/10 5:29 AM, Andriy Gapon wrote: > on 29/08/2010 01:18 Joe Marcus Clarke said the following: >> On 8/28/10 4:02 PM, Andriy Gapon wrote: >>> on 28/08/2010 22:28 Joe Marcus Clarke said the following: >>>> >>>> Try http://www.marcuscom.com/downloads/patch-hald_hf-storage.c >>> >>> Just wondering aloud... Would the same strange things (mentioned in the comment >>> in the patch) happen with labels for other filesystems like msdos/ cd9660/ ? >>> Or it's something specific to UFS? >>> >> >> Yeah, it could happen for other labels, I suppose. The problem is that >> the labels that appear dynamically depending oh whether or not a device >> is mounted confuses hal. If someone mounts /dev/cd0, unmounts it, then >> sees /dev/cd9660/FREEBSD appear, that will cause hal to think a new >> device was inserted. >> >> That said, I've only seen this happen with UFS. > > > BTW, there seems to be an exclamation mark missing in the following part of the > patch (hope you use monospaced font): > > + ! strcmp(fields[1], "PART")) && > + ! (strncmp(fields[2], "ufsid/", strlen("ufsid/")) || > Here----------^ > + ! strncmp(fields[2], "ufs/", strlen("ufs/")))) > > Ugh, you're right. When I added "ufs/" to the list, I broke the logic. It should be fixed now. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C7A893C.2070000>