Date: Mon, 22 Nov 2010 09:30:23 -0500 From: John Baldwin <jhb@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-current@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: removing tq_name [Was: taskqueue_create() name parameter lieftime] Message-ID: <201011220930.23179.jhb@freebsd.org> In-Reply-To: <4CE79C42.6000103@freebsd.org> References: <4CE2771F.8020109@freebsd.org> <201011191158.19118.jhb@freebsd.org> <4CE79C42.6000103@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, November 20, 2010 5:00:34 am Andriy Gapon wrote: > on 19/11/2010 18:58 John Baldwin said the following: > > On Friday, November 19, 2010 11:20:04 am Andriy Gapon wrote: > >> BTW, tq_name doesn't seem to be used anywhere at all. > >> Perhaps just drop it? But still could be useful in a debugger, though. > > > > If it's not used anywhere I would just drop it. > > > > struct taskqueue is defined privately in sys/kern/subr_taskqueue.c and tq_name > is used "write-only" in _taskqueue_create(). > > So, no use for tq_name at all? No. Especially since the structure is private it can always be revived if a use is found for it. You can probably leave the taskqueue_create() API the same for now though. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011220930.23179.jhb>