Date: Mon, 22 Nov 2010 12:32:06 +0000 From: Paul B Mahol <onemda@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: hackers@freebsd.org Subject: Re: Remove printf in acpi_tz_sanity() Message-ID: <AANLkTi=Z85E_CfyKWArbuYnwTxtpCn7EtW_u7ox2yj0r@mail.gmail.com> In-Reply-To: <4CEA328C.2060508@freebsd.org> References: <AANLkTimThbVyXmgU76m44GTzR0qGAQuJt-9xwunP-QdQ@mail.gmail.com> <4CE98C7E.90301@freebsd.org> <AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9@mail.gmail.com> <4CEA328C.2060508@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/22/10, Andriy Gapon <avg@freebsd.org> wrote: > on 22/11/2010 01:18 Paul B Mahol said the following: >> On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <avg@freebsd.org> wrote: >>> As is - this is a perfect candidate for a "local only" patch. >>> To be included into the tree - this, most probably, has to be controlled >>> by a >>> tunable/sysctl. >> >> So solution for useless console spamming is to add useless sysctl. > > Are you absolutely sure that they both are/would be useless? > For all uses of acpi_tz_sanity()? > E.g. if some system has never produced those messages in years and then > suddenly > starts spewing them out, would that be useless information? Linux, OpenBSD are missing this killer feature. > >> For -1 values, sane default values should be picked up. > > For current temperature too? > >> Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for >> tz0. > > On your system. > >> I'm not first one mentioning this and issue is old several years. > > OK. Sorry.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=Z85E_CfyKWArbuYnwTxtpCn7EtW_u7ox2yj0r>