Date: Mon, 29 Aug 2011 13:30:37 +0200 From: Andre Oppermann <andre@freebsd.org> To: Lawrence Stewart <lstewart@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: tcp failing to recover from a packet loss under 8.2-RELEASE? Message-ID: <4E5B785D.6000009@freebsd.org> In-Reply-To: <4E5AD893.7010708@freebsd.org> References: <E18D678F05BB4F3B93ADEB304CCA8504@multiplay.co.uk><1F95A4C2D54E4F369830143CBDB5FF86@multiplay.co.uk><4E37C0F2.4080004@freebsd.org><2B063B6D95AA4C27B004C50D96393F91@multiplay.co.uk><C706DEE346684B8DB06CFC090F556E72@multiplay.co.uk><4E3AA66A.6060605@freebsd.org><20229216858044E4881642284F245750@multiplay.co.uk> <4E432CB2.3030700@freebsd.org> <177917182AAD46A3962139F22B835B37@multiplay.co.uk> <4E5AD893.7010708@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29.08.2011 02:08, Lawrence Stewart wrote: > On 08/14/11 23:53, Steven Hartland wrote: >> ----- Original Message ----- From: "Lawrence Stewart" >> <lstewart@freebsd.org> >>> >>> Here's my tweaked version of Andre's patch: >>> http://people.freebsd.org/~lstewart/patches/misctcp/tcp_reass.c-logdebug%2bmissingsegment-20110811-lstewart.diff >>> >>> >> >> Still testing this and just noticed that the patch fails to >> compile when INVARIANTS is enabled. The KASSERT calls need >> ()'s around the split strings. > > oops, sorry. Compile tested on 8-STABLE without INVARIANTS enabled :/ > > Any further feedback with respect to the patch? Plan to submit it to re@ later this week for > inclusion in 9.0. I'm not sure these excessive KASSERT's are really necessary. Probably one covering those cases at the start of the function is sufficient. I was about to send the original patch to re@ for approval as well now that I'm back from vacation and fully available again. Don't mind if you do it if you've got the time. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E5B785D.6000009>