Date: Wed, 20 Jun 2012 10:45:38 +0200 From: Beat Gaetzi <beat@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: freebsd-ports@freebsd.org, "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com> Subject: Re: clang, dbus, firefox+thunderbird Message-ID: <CAJTLrNwyhSnzC8Qjqfc%2B1phX_SFdiRPm=9bnjvBKYjZEn1Nh=g@mail.gmail.com> In-Reply-To: <4FE18BB5.5040803@passap.ru> References: <4FE097DA.30701@passap.ru> <CALa-7vwOaw5hwMGdDN497KCG=qn3NK_hPA8VYeDCDErE6oSmvQ@mail.gmail.com> <4FE18BB5.5040803@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
2012/6/20 Boris Samorodov <bsam@passap.ru>: > Hi All, > > Andrew, thanks for your time and help! > > 19.06.2012 21:14, Andrew W. Nosenko =CE=C1=D0=C9=D3=C1=CC: > >> On Tue, Jun 19, 2012 at 6:16 PM, Boris Samorodov<bsam@passap.ru> =9Awrot= e: >>> >>> Hi List, >>> >>> I use clang compiled world (WITH_CLANG_IS_CC=3D"YES" and >>> WITH_LIBCPLUSPLUS=3D"YES" at /etc/make.conf). The system >>> is current: >>> ----- >>> % uname -a >>> FreeBSD bsam.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #16 r237055: Thu >>> Jun >>> 14 17:16:43 SAMT 2012 =9A =9A bsam@bsam.wart.ru:/usr/obj/usr/src/sys/BB= X >>> =9Ai386 >>> ----- >>> >>> While updating to the latest firefox I get an error: >>> ----- >>> /usr/local/include/dbus-1.0/dbus/dbus-protocol.h:459:77: error: invalid >>> suffix on literal; C++11 requires a space between literal and identifie= r >>> [-Wreserved-user-defined-literal] >>> #define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLI= C >>> >>> \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0= _XML_SYSTEM_IDENTIFIER"\">\n" >>> >>> =9A =9A ^ >>> >>> >>> /usr/local/include/dbus-1.0/dbus/dbus-protocol.h:459:126: error: invali= d >>> suffix on literal; C++11 requires a space between literal and identifie= r >>> [-Wreserved-user-defined-literal] >>> #define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLI= C >>> >>> \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0= _XML_SYSTEM_IDENTIFIER"\">\n" >>> >>> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A= =9A =9A =9A =9A =9A =9A =9A =9A =9A^ >>> >>> >>> 2 errors generated. >>> >>> ----- >>> >>> OK, I did make config and deselect DBUS. Great, firefox compiles and >>> installs (the latest one, 13.0.1). Then I try to upgrade thunderbird >>> and get the same error. However there is no option DBUS to disable. >>> >>> What am I to do? >>> Thanks! >> >> >> It's because of =9A"User defined literals" (the new c++11 feature) and >> your clang++ is in c++11 (or gnu++11?) mode by default. >> >> As workaround, you may try either: "downgrade" to something like gnu++ >> 98 (-std=3Dgnu++98), or edit dbus-protocol.h header for make it c++11 >> compatible. =9AIt's easy: just add spaces around >> DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER and >> DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER literals in the line 459 >> (just as compiler suggested). >> >> I.e. the line 459 >> >> =9A #define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node >> PUBLIC >> \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0_= XML_SYSTEM_IDENTIFIER"\">\n" >> >> should be written as >> >> =9A #define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node >> PUBLIC \"" DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER "\"\n\"" >> DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER "\">\n" > > > You are right. And AFAIK a similar fix was committed to the ports tree > while I was testing your suggestion. > > The fix helped clang to build firefox with DBUS on. However, > thunderbird stopped building with another error. I'll create > a new thread on the matter after some testing. There are patches to build Thunderbird with clang: http://lists.freebsd.org/pipermail/freebsd-gecko/2012-June/002273.html Maybe you could give them a try. Beat
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJTLrNwyhSnzC8Qjqfc%2B1phX_SFdiRPm=9bnjvBKYjZEn1Nh=g>