Date: Thu, 31 Dec 2009 14:15:10 -0500 From: Glen Barber <glen.j.barber@gmail.com> To: ports@freebsd.org Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, Doug Barton <dougb@freebsd.org> Subject: Re: cvs commit: ports/mail/p5-qpsmtpd/files qpsmtpd.in Message-ID: <4ad871310912311115g5c821d0bhd5d6c03f167deef1@mail.gmail.com> In-Reply-To: <4ad871310912141329r540d5cd9of33ec2963dbf999d@mail.gmail.com> References: <200912100507.nBA577Q3033700@repoman.freebsd.org> <4B2330FB.70309@FreeBSD.org> <4B243FBC.8080507@p6m7g8.com> <4B26A861.2080805@FreeBSD.org> <4ad871310912141329r540d5cd9of33ec2963dbf999d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00151747c366ecd9b5047c0b129c
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Hi,
On Mon, Dec 14, 2009 at 4:29 PM, Glen Barber <glen.j.barber@gmail.com> wrot=
e:
> On Mon, Dec 14, 2009 at 4:04 PM, Doug Barton <dougb@freebsd.org> wrote:
>> Philip M. Gollucci wrote:
>>>=A0I need to update it 0.83 anyway.
>>> I was going to rewrite the whole rc.d script from sratch at that time.
>>> In the meantime though this particular thing should help that person
>>> until I have time.
[...]
>
> I can have another look at this either tonight or tomorrow evening,
> unless someone updates it beforehand. =A0I will even update to 0.83 in
> the process.
>
I have attached two diffs of the rc script, however I have run into a
few issues with both.
The first diff still uses 'stop_cmd(){kill `cat $pidfile`}' for the
following reasons:
- adding ': qpsmtpd_pidfile=3D"$pidfile"' would never create
/var/run/qpsmtpd.pid, thus the rc script would never find it to kill
the process. To work around this, I added the pidfile creation to
start_cmd().
- as a side effect of the above workaround, stopping the process
would kill the PID, however leave the pidfile. As a second
workaround, I have kept the stop_cmd() function, and forcibly removed
the pidfile after the process was killed.
The second replaces the pidfile line with this:
[ -z "$pidfile" ] && pidfile=3D"/var/run/${name}.pid"
and adds a command_args line, however the pidfile is still not cleaned
after stopping the service, so stop_cmd() is used again. Is there a
more correct way to clean up the pidfile that what I have attached?
Regards, and have a happy and safe new year.
--=20
Glen Barber
--00151747c366ecd9b5047c0b129c
Content-Type: text/plain; charset=US-ASCII; name="qpsmtpd.1.txt"
Content-Disposition: attachment; filename="qpsmtpd.1.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g3vwu3yj0
LS0tIHFwc210cGQuaW4uMS5vcmlnCTIwMDktMTItMzEgMTQ6MDI6MTYuMDAwMDAwMDAwIC0wNTAw
CisrKyBxcHNtdHBkLmluLjEJMjAwOS0xMi0zMSAxNDowNDoxNi4wMDAwMDAwMDAgLTA1MDAKQEAg
LTE2LDg1ICsxNiwzMCBAQAogCiBuYW1lPSJxcHNtdHBkIgogcmN2YXI9YHNldF9yY3ZhcmAKLWxv
YWRfcmNfY29uZmlnICRuYW1lCitwaWRmaWxlPSIvdmFyL3J1bi9xcHNtdHBkLnBpZCIKIAogY29t
bWFuZD0iJSVQUkVGSVglJS9iaW4vcXBzbXRwZC1mb3Jrc2VydmVyIgotcGlkZmlsZT0iL3Zhci9y
dW4vcXBzbXRwZC9xcHNtdHBkLnBpZCIKIAotc3RhcnRfcHJlY21kPSJzdGFydF9wcmVjbWQiCiBz
dGFydF9jbWQ9InN0YXJ0X2NtZCIKIHN0b3BfY21kPSJzdG9wX2NtZCIKIAotc3RhcnRfcHJlY21k
KCkKLXsKLSAgICAjZXhpdHMgaWYgbm8gdXNlciBpcyBzcGVjaWZpZWQKLSAgICBpZiBbIC16ICRx
cHNtdHBkX3VzZXIgXTsgdGhlbgotCWVjaG8gInFwc210cGRfdXNlciBub3Qgc2V0IgotCWV4aXQg
MQotICAgIGZpCi0KLSAgICAjZXhpdHMgaWYgbm8gZ3JvdXAgaXMgc3BlY2lmaWVkCi0gICAgaWYg
WyAteiAkcXBzbXRwZF9ncm91cCBdOyB0aGVuCi0JZWNobyAicXBzbXRwZF9ncm91cCBub3Qgc2V0
IgotCWV4aXQgMQotICAgIGZpCi0KLSAgICAjc2V0cyBpdCB0byB0aGUgZGVmYXVsdCBpZiB0aGUg
cG9ydCBpcyBub3Qgc3BlY2lmaWVkCi0gICAgaWYgWyAteiAkcXBzbXRwZF9wb3J0IF07IHRoZW4K
LQlxcHNtdHBkX3BvcnQ9IjI1MjUiCi0gICAgZmkKLSAgICAKLSAgICAjc2V0IGl0IHRvIHRoZSBk
ZWZhdWx0IG1heCBwZXIgaXAKLSAgICBpZiBbIC16ICRxcHNtdHBkX21heF9wZXJfaXAgXTsgdGhl
bgotCXFwc210cGRfbWF4X3Blcl9pcD0iNSIKLSAgICBmaQotICAgIAotICAgICNzZXQgaXQgZG8g
dGhlIG1heCBudW1iZXIgb2YgY29ubmVjdGlvbnMgdG90YWwKLSAgICBpZiBbIC16ICRxcHNtdHBk
X21heF9jb25uZWN0aW9ucyBdOyB0aGVuCi0JcXBzbXRwZF9tYXhfY29ubmVjdGlvbnM9IjE1Igot
ICAgIGZpCi0gICAgCi0gICAgI3NldCB0aGUgZGVmYXVsdCBsaXN0ZW4gb24gdG8gZXZlcnl0aGlu
ZwotICAgIGlmIFsgLXogJHFwc210cGRfbGlzdGVuX29uIF07IHRoZW4KLQlxcHNtdHBkX2xpc3Rl
bl9vbj0iMC4wLjAuMCIKLSAgICBmaQotCi0gICAgaWYgWyAhIC1kIC92YXIvcnVuL3Fwc210cGQv
IF0gOyB0aGVuCi0JbWtkaXIgL3Zhci9ydW4vcXBzbXRwZAotICAgIGZpCi0gICAgCi0gICAgY2hv
d24gJHFwc210cGRfdXNlcjokcXBzbXRwZF9ncm91cCAvdmFyL3J1bi9xcHNtdHBkICAgIAotfQot
Ci1zdGFydF9jbWQoKQotewotCWlmIFsgLWUgJHBpZGZpbGUgXTsgdGhlbgotCQllY2hvICIkbmFt
ZSBhbHJlYWR5IHJ1bm5pbmcgYXMgUElEIGBjYXQgJHBpZGZpbGVgLiIKLQkJZXhpdCAxCi0JZWxz
ZQotCQlldmFsICRjb21tYW5kIFwKLQkJLXAgJHFwc210cGRfcG9ydCBcCi0JCS1jICRxcHNtdHBk
X21heF9jb25uZWN0aW9ucyBcCi0JCS11ICRxcHNtdHBkX3VzZXIgXAotCQktbSAkcXBzbXRwZF9t
YXhfcGVyX2lwIFwKLQkJLWwgJHFwc210cGRfbGlzdGVuX29uIFwKLQkJLS1waWQtZmlsZSAkcGlk
ZmlsZSBcCi0JCS1kIFwKLQkJJiYgZWNobyAiJG5hbWUgc3RhcnRlZCBhcyBQSUQgYGNhdCAkcGlk
ZmlsZWAuIiBcCi0JCXx8IGVjaG8gIkZhaWxlZCB0byBzdGFydCAkbmFtZSIKLQlmaQotfQotCi1z
dG9wX2NtZCgpCi17Ci0JaWYgWyAtZSAkcGlkZmlsZSBdOyB0aGVuCi0JCWtpbGwgYGNhdCAkcGlk
ZmlsZWAgXAotCQkmJiBlY2hvICIkbmFtZSBzdG9wcGVkLiIgXAotCQl8fCBlY2hvICJDb3VsZCBu
b3Qgc3RvcCBgY2F0ICRwaWRmaWxlYC4iCi0JZWxzZQotCQllY2hvICJDYW5ub3QgZmluZCAkcGlk
ZmlsZSAtICRuYW1lIG5vdCBydW5uaW5nPyIKLQkJZXhpdCAxCi0JZmkKK2xvYWRfcmNfY29uZmln
ICRuYW1lCis6IHFwc210cGRfZW5hYmxlPSJOTyIKKzogcXBzbXRwZF91c2VyPSJzbXRwZCIKKzog
cXBzbXRwZF9ncm91cD0ic210cGQiCis6IHFwc210cGRfcG9ydD0iMjUyNSIKKzogcXBzbXRwZF9t
YXhfcGVyX2lwPSIzIgorOiBxcHNtdHBkX21heF9jb25uZWN0aW9ucz0iMTUiCis6IHFwc210cGRf
bGlzdGVuX29uPSIwLjAuMC4wIgorCitzdGFydF9jbWQoKSB7CisJZWNobyAiU3RhcnRpbmcgJG5h
bWUuIgorCWV2YWwgJGNvbW1hbmQgLWQgLS1waWQtZmlsZSAkcGlkZmlsZQorfSAKKworc3RvcF9j
bWQoKSB7CisJZWNobyAiU3RvcHBpbmcgJG5hbWUuIgorCWtpbGwgYGNhdCAkcGlkZmlsZWAgJiYg
cm0gJHBpZGZpbGUKIH0KIAogcnVuX3JjX2NvbW1hbmQgIiQxIgo=
--00151747c366ecd9b5047c0b129c
Content-Type: text/plain; charset=US-ASCII; name="qpsmtpd.2.txt"
Content-Disposition: attachment; filename="qpsmtpd.2.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g3vwudyr1
LS0tIHFwc210cGQuaW4uMi5vcmlnCTIwMDktMTItMzEgMTQ6MDI6MTguMDAwMDAwMDAwIC0wNTAw
CisrKyBxcHNtdHBkLmluLjIJMjAwOS0xMi0zMSAxNDowNToxNy4wMDAwMDAwMDAgLTA1MDAKQEAg
LTE2LDg1ICsxNiwyNyBAQAogCiBuYW1lPSJxcHNtdHBkIgogcmN2YXI9YHNldF9yY3ZhcmAKLWxv
YWRfcmNfY29uZmlnICRuYW1lCiAKIGNvbW1hbmQ9IiUlUFJFRklYJSUvYmluL3Fwc210cGQtZm9y
a3NlcnZlciIKLXBpZGZpbGU9Ii92YXIvcnVuL3Fwc210cGQvcXBzbXRwZC5waWQiCiAKLXN0YXJ0
X3ByZWNtZD0ic3RhcnRfcHJlY21kIgotc3RhcnRfY21kPSJzdGFydF9jbWQiCiBzdG9wX2NtZD0i
c3RvcF9jbWQiCiAKLXN0YXJ0X3ByZWNtZCgpCi17Ci0gICAgI2V4aXRzIGlmIG5vIHVzZXIgaXMg
c3BlY2lmaWVkCi0gICAgaWYgWyAteiAkcXBzbXRwZF91c2VyIF07IHRoZW4KLQllY2hvICJxcHNt
dHBkX3VzZXIgbm90IHNldCIKLQlleGl0IDEKLSAgICBmaQotCi0gICAgI2V4aXRzIGlmIG5vIGdy
b3VwIGlzIHNwZWNpZmllZAotICAgIGlmIFsgLXogJHFwc210cGRfZ3JvdXAgXTsgdGhlbgotCWVj
aG8gInFwc210cGRfZ3JvdXAgbm90IHNldCIKLQlleGl0IDEKLSAgICBmaQotCi0gICAgI3NldHMg
aXQgdG8gdGhlIGRlZmF1bHQgaWYgdGhlIHBvcnQgaXMgbm90IHNwZWNpZmllZAotICAgIGlmIFsg
LXogJHFwc210cGRfcG9ydCBdOyB0aGVuCi0JcXBzbXRwZF9wb3J0PSIyNTI1IgotICAgIGZpCi0g
ICAgCi0gICAgI3NldCBpdCB0byB0aGUgZGVmYXVsdCBtYXggcGVyIGlwCi0gICAgaWYgWyAteiAk
cXBzbXRwZF9tYXhfcGVyX2lwIF07IHRoZW4KLQlxcHNtdHBkX21heF9wZXJfaXA9IjUiCi0gICAg
ZmkKLSAgICAKLSAgICAjc2V0IGl0IGRvIHRoZSBtYXggbnVtYmVyIG9mIGNvbm5lY3Rpb25zIHRv
dGFsCi0gICAgaWYgWyAteiAkcXBzbXRwZF9tYXhfY29ubmVjdGlvbnMgXTsgdGhlbgotCXFwc210
cGRfbWF4X2Nvbm5lY3Rpb25zPSIxNSIKLSAgICBmaQotICAgIAotICAgICNzZXQgdGhlIGRlZmF1
bHQgbGlzdGVuIG9uIHRvIGV2ZXJ5dGhpbmcKLSAgICBpZiBbIC16ICRxcHNtdHBkX2xpc3Rlbl9v
biBdOyB0aGVuCi0JcXBzbXRwZF9saXN0ZW5fb249IjAuMC4wLjAiCi0gICAgZmkKLQotICAgIGlm
IFsgISAtZCAvdmFyL3J1bi9xcHNtdHBkLyBdIDsgdGhlbgotCW1rZGlyIC92YXIvcnVuL3Fwc210
cGQKLSAgICBmaQotICAgIAotICAgIGNob3duICRxcHNtdHBkX3VzZXI6JHFwc210cGRfZ3JvdXAg
L3Zhci9ydW4vcXBzbXRwZCAgICAKLX0KLQotc3RhcnRfY21kKCkKLXsKLQlpZiBbIC1lICRwaWRm
aWxlIF07IHRoZW4KLQkJZWNobyAiJG5hbWUgYWxyZWFkeSBydW5uaW5nIGFzIFBJRCBgY2F0ICRw
aWRmaWxlYC4iCi0JCWV4aXQgMQotCWVsc2UKLQkJZXZhbCAkY29tbWFuZCBcCi0JCS1wICRxcHNt
dHBkX3BvcnQgXAotCQktYyAkcXBzbXRwZF9tYXhfY29ubmVjdGlvbnMgXAotCQktdSAkcXBzbXRw
ZF91c2VyIFwKLQkJLW0gJHFwc210cGRfbWF4X3Blcl9pcCBcCi0JCS1sICRxcHNtdHBkX2xpc3Rl
bl9vbiBcCi0JCS0tcGlkLWZpbGUgJHBpZGZpbGUgXAotCQktZCBcCi0JCSYmIGVjaG8gIiRuYW1l
IHN0YXJ0ZWQgYXMgUElEIGBjYXQgJHBpZGZpbGVgLiIgXAotCQl8fCBlY2hvICJGYWlsZWQgdG8g
c3RhcnQgJG5hbWUiCi0JZmkKLX0KLQotc3RvcF9jbWQoKQotewotCWlmIFsgLWUgJHBpZGZpbGUg
XTsgdGhlbgotCQlraWxsIGBjYXQgJHBpZGZpbGVgIFwKLQkJJiYgZWNobyAiJG5hbWUgc3RvcHBl
ZC4iIFwKLQkJfHwgZWNobyAiQ291bGQgbm90IHN0b3AgYGNhdCAkcGlkZmlsZWAuIgotCWVsc2UK
LQkJZWNobyAiQ2Fubm90IGZpbmQgJHBpZGZpbGUgLSAkbmFtZSBub3QgcnVubmluZz8iCi0JCWV4
aXQgMQotCWZpCi19Citsb2FkX3JjX2NvbmZpZyAkbmFtZQorOiBxcHNtdHBkX2VuYWJsZT0iTk8i
Cis6IHFwc210cGRfdXNlcj0ic210cGQiCis6IHFwc210cGRfZ3JvdXA9InNtdHBkIgorOiBxcHNt
dHBkX3BvcnQ9IjI1MjUiCis6IHFwc210cGRfbWF4X3Blcl9pcD0iMyIKKzogcXBzbXRwZF9tYXhf
Y29ubmVjdGlvbnM9IjE1IgorOiBxcHNtdHBkX2xpc3Rlbl9vbj0iMC4wLjAuMCIKKworWyAteiAi
JHBpZGZpbGUiIF0gJiYgcGlkZmlsZT0iL3Zhci9ydW4vJHtuYW1lfS5waWQiCisKK3N0b3BfY21k
KCkgeworCWVjaG8gIlN0b3BwaW5nICRuYW1lLiIKKwlraWxsIGBjYXQgJHBpZGZpbGVgICYmIHJt
ICRwaWRmaWxlCit9IAorCitjb21tYW5kX2FyZ3M9Ii1kIC0tcGlkLWZpbGUgJHBpZGZpbGUiCiAK
IHJ1bl9yY19jb21tYW5kICIkMSIK
--00151747c366ecd9b5047c0b129c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ad871310912311115g5c821d0bhd5d6c03f167deef1>