Date: Mon, 22 Oct 2012 13:47:04 -0400
From: John Baldwin <jhb@freebsd.org>
To: Andrey Chernov <ache@freebsd.org>
Cc: freebsd-stable@freebsd.org
Subject: Re: ${CTFCONVERT_CMD} expands to empty string
Message-ID: <201210221347.04727.jhb@freebsd.org>
In-Reply-To: <50857C01.8050500@freebsd.org>
References: <5081F92F.8040004@freebsd.org> <50857831.1070603@freebsd.org> <50857C01.8050500@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, October 22, 2012 1:01:53 pm Andrey Chernov wrote:
> All that happens because this commit is not merged into stable-9.
> Do you plan to mere it by yourself?
>=20
> r228157 | fjoe | 2011-11-30 22:07:38 +0400 (=D3=D2, 30 =CE=CF=D1 2011) | =
10 lines
>=20
> - Fix segmentation fault when running "+command" when run with -jX -n due
> to Compat_RunCommand() being called with `cmd' that is not on the node-
>commands
> list
> - Make ellipsis ("..." command) handling consistent: check for "..." comm=
and
> in job make after variables expansion to match compat make behavior
> - Fix empty command handling (after variables expansion and @+- modifiers
> are processed): now empty commands are ignored in compat make and are not
> printed in job make case
> - Bump MAKE_VERSION to 5-2011-11-30-0
As soon as I can reproduce something that tests it, sure (I want to have a=
=20
test case I can reproduce so that I can also check for 8). Your test
Makefile does break on 8 and 9, want to do some more tests.
> On 22.10.2012 20:45, Andrey Chernov wrote:
> > And simple test case proving that make v9201206140 dislike empty comman=
ds.
> > Makefile:
> > ------------------------------------------------
> > CTFCONVERT_CMD=3D
> > all:
> > echo ${MAKE_VERSION}
> > ${CTFCONVERT_CMD}
> > echo b
> > ------------------------------------------------
> >> make
> > echo 9201206140
> > 9201206140
> > ${CTFCONVERT_CMD} expands to empty string
> > echo b
> > b
=2D-=20
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210221347.04727.jhb>