Date: Sun, 16 Dec 2012 06:13:53 -0500 From: "Jason E. Hale" <jhale@freebsd.org> To: Ruslan Makhmatkhanov <cvs-src@yandex.ru> Cc: marco.broeder@gmx.eu, freebsd-ports@freebsd.org, bug-followup@freebsd.org Subject: Re: [@ ports committers] ports/173531 Message-ID: <3096099.yLIANgpWSo@mocha.verizon.net> In-Reply-To: <50CDAB84.5050701@yandex.ru> References: <50CD99F2.4010205@gmx.eu> <50CDA9A7.7010401@yandex.ru> <50CDAB84.5050701@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, December 16, 2012 15:07:48 Ruslan Makhmatkhanov wrote:
> Ruslan Makhmatkhanov wrote on 16.12.2012 14:59:
> > Hi Marco,
> >=20
> > Marco Br=F6der wrote on 16.12.2012 13:52:
> >> Hi,
> >>=20
> >> could a ports committer take ports/173531 pr, please? It is unassi=
gned
> >> for
> >> over a month, now.
> >>=20
> >> Thank you very much!
> >=20
> > Please review patch attached. I changed some things in your patch:
> > - using OPTIONSFILE instead of UNIQUENAME (it's common practice to =
fix
> >=20
> > things like that)
> >=20
> > - limit to python 2.x (dulwich is not python 3.x-aware yet)
> > - tab -> space change in pkg-descr:WWW (style bug)
> > - remove DOCS_DESC (we have generic description in bsd.options.desc=
.mk)
> > - use PYTHON_CMD instead of ``/usr/bin/env python'' (to make sure i=
t
> >=20
> > will be runned with the same python branch, that it was built wi=
th)
> >=20
> > Please let me know if you agree with the changes, and I commit the
> > update shortly.
> >=20
> > PS. Surely, it builds fine with this patch.
>=20
> Oops, I see that this pr was taken by jhale already :)
Ruslan,
If you want to take this that is fine with me...I haven't started worki=
ng on=20
it yet and it seems you have looked into it already.
> One more thing - PORTDOCS should be defined uncoditionally, but
> installed conditionally:
>=20
> +.if ${PORT_OPTIONS:MDOCS}
> +PORTDOCS=3D=09AUTHORS COPYING HACKING NEWS README introduction.txt \=
> +=09=09object-store.txt protocol.txt remote.txt repo.txt
> .endif
>=20
COPYING should be removed here too. LICENSE is already defined.
> This condition is not necessary.
--=20
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3096099.yLIANgpWSo>