Date: Thu, 07 Feb 2013 18:03:32 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: ports@FreeBSD.org, Brooks Davis <brooks@freebsd.org>, Dewayne Geraghty <dewayne.geraghty@heuristicsystems.com.au> Subject: Re: openssh-portable segmentation faults Message-ID: <511440D4.5060603@FreeBSD.org> In-Reply-To: <51143DC7.7070902@FreeBSD.org> References: <67A39057348F4D1BA43004DB5F0E8DBB@white> <5113B343.303@FreeBSD.org> <CD64A9A7097A415CB05541C9032576D1@white> <511435D8.8000900@FreeBSD.org> <51143DC7.7070902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IVHWFQHDRFQSTFVWEIFD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2/7/2013 5:50 PM, Dimitry Andric wrote: > On 2013-02-08 00:16, Dimitry Andric wrote: >> On 2013-02-07 22:14, Dewayne Geraghty wrote: >> ... >>> Bryan, Dimitry, >>> Thank-you for your interest. >>> Unfortunately we have no debugging tools on any of the machines. I'll= >>> build one today and reproduce. > ... >> Executive summary: we recently imported a strnvis() implementation fro= m >> NetBSD, which has differently ordered arguments from the strnvis() >> implementation in OpenBSD. When OpenSSH calls it with arguments order= ed >> in the way OpenBSD expects, the function segfaults. >=20 > And here is a patch, which works for me. It simply disables use of > libc's strnvis(), forcing the port to use its own bundled version. Perfect thanks. This was the approach I was going to take as well, since it has a bundled compatibility version already. Fix Committed. --=20 Regards, Bryan Drewery bdrewery@freenode/EFNet ------enig2IVHWFQHDRFQSTFVWEIFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRFEDUAAoJEG54KsA8mwz5CsIP/iMNMTia1+Z0rF/N7avuHTC4 4H0l7xn6y5bvPJgbuhvlF/HzBC8Xyf0fFsVNFfbmVKjxi1OQ8GI6Tykq8DjoapDs vE4ZwBX1E8QP7ilRcuq3vov0iP9+k9ojPnSS2uhSrp69BhJLuOSWvVTs9F7BoZfk 6Xdj7Eps7k9ThtyVMMBd6blJYvtD6dOhZhoYuH3G9IgbJj5yVNpR6QiRC/XPXEvR 1Ja8OUoRT5l5Gq3W17WJDybCV/FL4aEcvpjx/WBT9EJOH0E/eDHZ2FXk060FOXay ZG+QPE+VCa8qGqitVOMNjeyo3ZvlRPWWtFqfTl/GTqcN6Ngiu81uf+p/R93kRSvv 0UhJT/kM2VjciZ8btlIaH8qj6bc4PTZcY++WmBxKGxPI8M1HT2GtI46c4ubjaWga cFg+EAODBSobDSfww/I19HbRFijkpQ49orVmJljiVQolYFeoNz3vLdhL7HNhVorR o3WDFGn4+4Ak8AemESzYoGWV4gP7iaFqx9HXHTcNeHbEY+iNzBYM78oEzLiEmGaQ a9A+lKEBA8enRfpsWQuHQXtJwQJfUUsWlTWEEico61iox8kO/D1Wx+b4gNVYPTya M6kIH8wCHs7c1d6R1AAE+HXIZd2xvEvvpeDSBsVd5lqkUj/KRo8hU+NjjKvyjehe 01HsRiucgNJp+/omfuqL =31Sh -----END PGP SIGNATURE----- ------enig2IVHWFQHDRFQSTFVWEIFD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511440D4.5060603>