Date: Sat, 2 Nov 2013 16:22:30 -0800 From: Royce Williams <royce@tycho.org> To: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Automated submission of kernel panic reports Message-ID: <CA%2BE3k92eEcK8bZCSp6Sg1V-JwN7YB8ViG8TjK0x5ChvO5ByCcQ@mail.gmail.com> In-Reply-To: <52759664.50800@freebsd.org> References: <526F8EB3.1040205@freebsd.org> <20131102171840.4505cb02@b1c1l1.com> <52759664.50800@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 2, 2013 at 4:18 PM, Colin Percival <cperciva@freebsd.org> wrote: > On 11/02/13 17:18, Benjamin Lee wrote: > > On Tue, 29 Oct 2013 03:32:19 -0700, Colin Percival <cperciva@freebsd.org> > wrote: > >> Hi all, > >> > >> I've written some code for automatically submitting kernel panic > reports, > >> and I'd like some feedback before I place it into the ports tree. > > > > Just a style question, any reason not to place the file names into > > variables? Something like: > > No reason to avoid it, I just don't see any need. It's definitely more "quickly legible" to the human trying to grok the code. Royce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BE3k92eEcK8bZCSp6Sg1V-JwN7YB8ViG8TjK0x5ChvO5ByCcQ>