Date: Sat, 6 Sep 2014 18:41:09 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Pieter de Goeje <pieter@degoeje.nl> Cc: Alan Cox <alc@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, "freebsd-hackers@freebsd.org" <hackers@freebsd.org> Subject: Re: mmap MAP_NOSYNC regression in 10.x Message-ID: <20140906154109.GV2737@kib.kiev.ua> In-Reply-To: <540B23F4.1040608@degoeje.nl> References: <540903FF.6010602@degoeje.nl> <CAJUyCcNiLwLuL9crpQBjSdg4ED5kR53fPjyJG3HNmP5Roor8RQ@mail.gmail.com> <20140905080633.GM2737@kib.kiev.ua> <5409A4F8.6020204@degoeje.nl> <20140905123826.GP2737@kib.kiev.ua> <CAJ-Vmo=Dw02HsazH1n9wkXFDXM83bOnNLGndAt5=KZN9QHxyOw@mail.gmail.com> <20140906074849.GS2737@kib.kiev.ua> <540B23F4.1040608@degoeje.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--iQrD/dScPhU9JStb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 06, 2014 at 05:10:44PM +0200, Pieter de Goeje wrote: > Konstantin Belousov schreef op 6-9-2014 9:48: > > On Fri, Sep 05, 2014 at 12:46:31PM -0700, Adrian Chadd wrote: > >> Is this worth putting into the regression test suite? > > I do not have opinion on this. Feel free to do if you consider it wort= h. > > > > Note that the code needs some tweaking to become automated test. > > Also, there is no copyright assigned on the test, so you need > > to handle this as well. > > >=20 > I can take a stab at converting it to something suitable for inclusion=20 > under tools/regression. One issue is that the test uses a heuristic to=20 > determine success or failure. I don't really see a way around that,=20 > although it certainly could be improved. This is sort of what I mean about tweaking, besides using the standard test report format. If you provide complete patch for test case, somebody (or me if nobody else volunteer) will definitely commit it. --iQrD/dScPhU9JStb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUCysVAAoJEJDCuSvBvK1B9VAP/ika/6y8YlZQ7KN/mIx8shvM A+wZaIYlS7ahHeyAKKfzS+591qwTlmcB4xP101m4jSSJvm3REFmTcA3UjmQyu6Jc HQNcvUfoynbZyhQWm8vQk3wVKv8XEjQ9v9rDSaacA0CX/hVd/PD+4e75q8w8/jaF HiG7voQd/zDXCGz6rQfRvRG6O/S+xZqaT7n0UZpmABZmZu+ZA24wHB1+SEFQAwrQ OyiQzhe+HdVm4X8tzsrIb5G95lzLwJ0FUFU+qhcDwxN1XVMz4xxSNWdmPlgLWDc5 IZ3QRFvUqDcA/RaamBmRuKuodvqhj+nUbHIZWxMO0voxeNx0fVcfy3k00MIyDRmJ MTFknpAZYbzIycHv0Wj3R89SmlBPzTocaiLUfnQntEKUudBqm2uIpSWa9WUks5IP +B8FJTemRrR3BGhCCh++UwNKplhqE4H//UbhtPiPcg2oC101j3TeTAijZGKJX63y V3gYXLyu0H4ED9txJDDz3rxW3tFC4Fg/O4y7OkfbnqMyT51lA+3TUMcpidojrypP IflsyLSQqn7HV600x46CFFSZmK/PBgu/VqZOUl4dihmEdUcDcCxzIbpbjx9bewTC XKTqQsWYOcjYnia44HYPkh4i1qGKOJ082wW5XsH1WdnSVX7LlRBtpoa0CeWIxUw+ iJ3mKt1Frf47N9yC0Z2n =2RJr -----END PGP SIGNATURE----- --iQrD/dScPhU9JStb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140906154109.GV2737>