Date: Fri, 03 Oct 2014 05:05:52 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: dumbbell@FreeBSD.org Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net Message-ID: <20141003.050552.130574284942561369.hrs@allbsd.org> In-Reply-To: <542D9AED.6060805@FreeBSD.org> References: <201410012137.s91LbXL4025967@svn.freebsd.org> <542D9AED.6060805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Jean-Sébastien Pédron <dumbbell@FreeBSD.org> wrote in <542D9AED.6060805@FreeBSD.org>: du> > Author: hrs du> > Date: Wed Oct 1 21:37:32 2014 du> > New Revision: 272386 du> > URL: https://svnweb.freebsd.org/changeset/base/272386 du> > du> > Log: du> > Virtualize lagg(4) cloner. This change fixes a panic when tearing down du> > if_lagg(4) interfaces which were cloned in a vnet jail. du> du> Hi! du> du> I believe this change needs at least an entry in UPDATING, because an du> ifconfig(8) binary built before this commit fails to change laggproto on du> a kernel including this commit. du> du> The error is the following: du> # ifconfig lagg0 laggproto failover du> ifconfig: SIOCSLAGG: Invalid argument du> du> By quickly looking at the code, I would say that the culprit is the du> change in size of the "struct lag_reqall". The new "ra_opts" field in du> "struct lagg_reqall" isn't initialized in the incompatible ifconfig(8) du> binary. This could be considered invalid options, leading to "error = du> EINVAL" in if_lagg.c:1301. du> du> Another non-critical regression is that this ifconfig(8) binary doesn't du> display the laggproto and laggport lines. I mean those lines: du> # ifconfig lagg0 du> lagg0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> (...) du> (...) du> laggproto failover lagghash l2,l3,l4 du> laggport: wlan0 flags=0<> du> laggport: re0 flags=5<MASTER,ACTIVE> du> du> Beside an UPDATING entry, how about a previously released world with du> this new kernel? Isn't this configuration supposed to work? Ah, yes, I was lazy and did not keep the compatibility. On or after r272446 an old ifconfig works with the new kernel. -- Hiroki [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlQtsCAACgkQTyzT2CeTzy2zLACeP1+8fSGbBvGQX19z/7cYX1pV OU0An2VXcxOGpxjqPTCoZ7nUYxnAQeae =VZyS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141003.050552.130574284942561369.hrs>