Date: Thu, 10 Jan 2002 12:47:25 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Anders Nor Berle <debolaz@debolaz.com> Cc: freebsd-bugs@FreeBSD.org, sheldonh@FreeBSD.org Subject: Re: kern/33124: kthread_create doesnt mark kthreads as kthreads. Message-ID: <XFMail.020110124725.jhb@FreeBSD.org> In-Reply-To: <54540.62.179.128.205.1010684965.squirrel@webmail.debolaz.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10-Jan-02 Anders Nor Berle wrote: >> >> This is actually kind of bogus. Nobody uses this flag except aio, and aio >> just sets >> the flag, no code actually checks it. P_KTHREAD is a new flag in -current >> used in a >> few places. Unless the submitter has code that actually checks P_KTHREADP >> and needs >> it set for some reason, I would rather see the flag killed. One thing that >> might be >> nice to MFC is changing aio to use kthread_create rather than using its own >> home-rolled version. >> > Well, I do have some code, related to jail, which checks for P_KTHREADP, but > if P_KTHREAD > becomes available instead, that'll do of course. I was just following what > was already > there. :) Hmm, how about this: kill P_KTHREADP, instead MFC fixes to aio to use the kthread API and then MFC the P_KTHREAD flag. How does that sound? Well, for backwards compatibility, it might be better to #define P_KTHREADP P_KTHREAD after you MFC P_KTHREAD rather than killing the flag. > - Anders Nor Berle -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020110124725.jhb>