Date: Sun, 2 Nov 2014 18:46:37 +0900 From: "Daisuke Aoyama" <aoyama@peach.ne.jp> To: "Hans Petter Selasky" <hps@selasky.org>, "Rui Paulo" <rpaulo@me.com> Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD 11-CURRENT on Raspberry Pi 512MB Message-ID: <7FEFD928A4254E84BCB539D523E9D571@ad.peach.ne.jp> In-Reply-To: <54548EC8.5020707@selasky.org> References: <0A8390C3FC2B444B9AA8AC934B79DCD6@ad.peach.ne.jp> <C9E25385-E665-4895-96CE-DCC71B36FF3B@me.com> <DF85948EF6CF4FF28BA12309FEFA1B67@ad.peach.ne.jp> <7946CCA3-26D0-4B6E-AEBB-8623CAAA9725@me.com> <840772A7305444C1B1AF7CE31A89BD7D@ad.peach.ne.jp> <09F2506B-11E9-43A2-A783-784AA6E39976@me.com> <5DC02CC61B85442AADD2BDD28496421E@ad.peach.ne.jp> <60F13E5C-A166-497B-8CB7-6C76AFB6BDB8@me.com> <54548EC8.5020707@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 11/01/14 02:54, Rui Paulo wrote: >> On Oct 31, 2014, at 12:32, Daisuke Aoyama <aoyama@peach.ne.jp> wrote: >>> >>>> That patch has a lot of unrelated changes. Could you produce a patch with svn that is just >>>> related to cpufreq and its mbox changes? >>> >>> I have uploaded as: >>> http://www.peach.ne.jp/archives/rpi/patch/cpufreq-20141101.tar.gz >>> >>> Please use this archive. >>> >>> CHANGES: >>> modify for style(9) and 80 columns >>> remove multiple cast >>> remove bootverbose of error case >>> remove unused code and g_XXXX variables >>> fix wrong message/comments. >>> add DPRINTF and dump into #ifdef DEBUG >>> add tunable int for verbose and lowest_freq >>> suppress default boot log >> >> Thanks, I've updated the review page: >> >> https://reviews.freebsd.org/D1025 >> >> I'm going to review it again during the weekend. >> >> > > Regarding the tunables: > > Why don't you make them into SYSCTLS with the TUN flag set. Then they will also be visible in > the "sysctl -a" output! Hi, The reason is that the existing code of bcm2835_sdhci.c is used. Does it is required in read-only? Regards, -- Daisuke Aoyama
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7FEFD928A4254E84BCB539D523E9D571>