Date: Wed, 19 Nov 2014 17:29:55 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Anton Yuzhaninov <citrin@citrin.ru> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r274710 - head/sbin/ifconfig Message-ID: <20141119142955.GF43381@glebius.int.ru> In-Reply-To: <546CA502.4020008@citrin.ru> References: <201411191357.sAJDvexm004236@svn.freebsd.org> <546CA502.4020008@citrin.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 19, 2014 at 05:11:14PM +0300, Anton Yuzhaninov wrote: A> On 11/19/14 16:57, Mark Felder wrote: A> > New Revision: 274710 A> > URL: https://svnweb.freebsd.org/changeset/base/274710 A> > A> > Log: A> > Expose groups by default in ifconfig output. This was never hidden by A> > OpenBSD; unsure why we chose to do so. As groups are a requirement for A> > pf, exposing them by default will make our pf implementation less A> > confusing. A> ... A> > A> > Modified: head/sbin/ifconfig/ifgroup.c A> > ============================================================================== A> > --- head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:31:08 2014 (r274709) A> > +++ head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:57:39 2014 (r274710) A> > @@ -86,9 +86,6 @@ getifgroups(int s) A> > struct ifgroupreq ifgr; A> > struct ifg_req *ifg; A> > A> > - if (!verbose) A> > - return; A> A> Please return groups output under verbose flag. A> A> pf is used not by all. A> A> And more longer ifconfig output is unhandy. Especially on hosts with many A> interfaces. A> A> Better to document ifconfig -v in pf.conf(5) Better to document it in ifconfig(8). Actually ifgroups are not a part of pf(5). And commit has nothing to do with "our pf implementation being confusing". P.S. I was pretty sure that users would not like changing defaults for ifconfig. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141119142955.GF43381>