Date: Wed, 25 Mar 2015 09:52:57 +0800 From: Julian Elischer <julian@freebsd.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, ports@freebsd.org Cc: mva@freebsd.org Subject: Re: patch to bsd.ports.mk to support out-of-tree patches. Message-ID: <551214F9.5070202@freebsd.org> In-Reply-To: <55121468.2040308@FreeBSD.org> References: <5510F71B.7030900@freebsd.org> <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu> <55121468.2040308@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/25/15 9:50 AM, Bryan Drewery wrote:
> On 3/24/2015 5:32 AM, Marcus von Appen wrote:
>> Julian Elischer <julian@freebsd.org>:
>>
>> [...]
>>> esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \
>>> done )
>>> .endif
>>> +.if defined(EXTRA_PATCH_TREE)
>> [...]
>>> +.endif
>>> .if defined(EXTRA_PATCHES)
>>> @set -e ; \
>>> for i in ${EXTRA_PATCHES}; do \
>>>
>>>
>>> ============
>> Nice. I'd however change the patch behaviour to the following:
>>
>> - patch-* from FreeBSD
>> - EXTRA_PATCHES from FreeBSD
>> - local patches
>>
>> Your patch looks like it appleis the out-of-tree patches prior
>> to any EXTRA_PATCHES defined by the port itself. This should not be
>> the case, in my opinion. Locally managed patches should always come
>> last to ensure that all FreeBSD/maintainer-specific bits have been
>> applied and the local changes are just added on top of those.
>>
>> Cheers
>> Marcus
>>
> Agreed. The local patches are intended to avoid touching the port. If
> they are not last then you may have to go tweaking some of the other
> ports patches to fix your own.
>
that makes sense.. it just means shifting the code down a bit..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?551214F9.5070202>