Date: Sun, 17 Jan 2016 00:57:58 -0500 From: Steve Wills <swills@FreeBSD.org> To: Matthew Seaman <m.seaman@infracaninophile.co.uk>, freebsd-ports@freebsd.org Subject: Re: Rubygem .js files fubar? Message-ID: <569B2D66.2070006@FreeBSD.org> In-Reply-To: <5694DF6C.3000204@infracaninophile.co.uk> References: <5693DB57.7090407@freebsd.org> <5694DF6C.3000204@infracaninophile.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 01/12/16 06:11 AM, Matthew Seaman wrote: > On 01/11/16 16:41, Matthew Seaman wrote: >> lucid-nonsense:...svn2git-2.3.2/rdoc/js:% ls -la >> total 140 >> drwxr-xr-x 2 matthew wheel 576 Jan 11 16:20 ./ >> drwxr-xr-x 7 matthew wheel 640 Jan 11 13:01 ../ >> -rw-r--r-- 1 matthew wheel 4666 Jan 11 13:01 darkfish.js >> -rw-r--r-- 1 matthew wheel 91669 Jan 11 13:01 jquery.js >> -rw-r--r-- 1 matthew wheel 3663 Jan 11 13:01 navigation.js >> -rw-r--r-- 1 matthew wheel 1127 Jan 11 13:01 navigation.js.gz >> -rw-r--r-- 1 matthew wheel 2992 Jan 11 13:01 search.js >> -rw-r--r-- 1 matthew wheel 3310 Jan 11 13:01 search_index.js >> -rw-r--r-- 1 matthew wheel 920 Jan 11 13:01 search_index.js.gz >> -rw-r--r-- 1 matthew wheel 6603 Jan 11 13:01 searcher.js >> -rw-r--r-- 1 matthew wheel 1791 Jan 11 13:01 searcher.js.gz >> >> As far as I can tell these are boilerplate installed by something to do >> with rdoc. A quick find(1) over my /usr/local/lib/ruby shows this same >> pattern in a number of installed rubygems. >> >> What's going on here? >> >> This makes poudriere sad, although the error message doesn't say >> anything about "I can't decompress this, because there's already a >> decompressed copy in the way" instead claiming the .gz files refer to >> some path under staging. > > So, it seems this affects every rubygem port -- there's compressed and > uncompressed copies of the same files installed for each and every gem. > And they all fail 'poudriere testport'. I can't recall all the details as it's been a while since I looked at this, but basically the original file name is getting stored in the .gz file (see gzip's -n flag). Fixing this will take patching ruby's ext/zlib/zlib.c. (rubygem is just calling that.) I've looked at patching this, but not completed it. I'll try to work on it some more. As for why the original file isn't deleted, I'm not sure. I don't see this in my local tree, but I have some changes that may be masking it. Poudriere is just grepping files for references to the wrkdir path and finding them. > Given that, I think I'll commit rubygem-svn2git as it seems to be > working at least as well as any other rubygem port. > This is fine. Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?569B2D66.2070006>