Date: Wed, 27 Jan 2016 09:55:41 -0700 From: Alan Somers <asomers@freebsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: syslogd(8) with OOM Killer protection Message-ID: <CAOtMX2jM4sys-0RgybosTV7zeuExgSXPt=YztibYVC061zQGvQ@mail.gmail.com> In-Reply-To: <56A8F5D4.2070901@freebsd.org> References: <CAOfEmZgzL2Ldu53CeSsKcUe00H1VAukhEopSUmpUK0=XAhsD1A@mail.gmail.com> <56A86D91.3040709@freebsd.org> <alpine.BSF.2.20.1601270932220.30320@wonkity.com> <56A8F5D4.2070901@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 27, 2016 at 9:52 AM, Allan Jude <allanjude@freebsd.org> wrote: > On 2016-01-27 11:36, Warren Block wrote: >> On Wed, 27 Jan 2016, Allan Jude wrote: >> >>> On 2016-01-27 01:21, Marcelo Araujo wrote: >>>> Hi guys, >>>> >>>> I would like to know your opinion about this REVIEW[1]. >>>> The basic idea is protect by default the syslogd(8) against been >>>> killed by >>>> OOM with an option to disable the protection. >>>> >>>> Some people like the idea, other people would prefer something more >>>> global >>>> where we can protect any daemon by the discretion of our choice. >>>> >>>> Thoughts? >>>> >>>> >>>> [1] https://reviews.freebsd.org/D4973 >>>> >>>> >>>> Best, >>>> >>> >>> I do like the idea of generalizing it, say via rc.subr >>> >>> So you can just do: >>> >>> someapp_protect=YES (and maybe syslogd has this enabled by default in >>> /etc/defaults/rc.conf) and it prefixes the start command with protect -i. >> >> Possibly simpler to provide a list in one setting than an individual >> setting for each daemon. With ideas from other posters: >> >> oomprotect_daemons="crond syslogd" >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > > > The only reason I went for daemon_protect="YES" was for ease of > implementation. It would just be another command prefix like: _nice, > _fib, or _env > > -- > Allan Jude > I agree with Allan. We already have a lot of <DAEMON>_foo variables. But there aren't any foo_daemons variables. For consistency's sake, we should use <DAEMON>_protect or <DAEMOM>_oomprotect. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2jM4sys-0RgybosTV7zeuExgSXPt=YztibYVC061zQGvQ>