Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Oct 2021 19:09:25 -0400
From:      Thomas Dickey <dickey@his.com>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        John Baldwin <jhb@FreeBSD.org>, marklmi@yahoo.com, freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: main changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS but /usr/lib/libdialog.so.? naming was not adjusted? (crashes in releng/13 programs on main [so: 14] can result)
Message-ID:  <20211022230925.GA17806@prl-debianold-64.jexium-island.net>
In-Reply-To: <5df871c1-08ff-4d36-bb11-1a93ce42c5aa@FreeBSD.org>
References:  <5270B5FE-6C3B-4172-A310-AE9A5A1B853A.ref@yahoo.com> <5270B5FE-6C3B-4172-A310-AE9A5A1B853A@yahoo.com> <d2612e19-d567-4a2f-2f25-38bad101861a@FreeBSD.org> <5df871c1-08ff-4d36-bb11-1a93ce42c5aa@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 22, 2021 at 04:11:56PM +0000, Baptiste Daroussin wrote:
>=20
> 22 oct. 2021 18:06:56 John Baldwin <jhb@FreeBSD.org>:
>=20
> > On 10/22/21 1:08 AM, Mark Millard via freebsd-current wrote:
> >> main [soi: 14] commit a96ef450 (2021-02-26 09:16:49 +0000)
> >> changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS .
> >> These are publicly exposed in (ones that I noticed):
> >> /usr/include/dialog.h:extern DIALOG_STATE dialog_state;
> >> /usr/include/dialog.h:extern DIALOG_VARS dialog_vars;
> >> /usr/include/dialog.h:extern DIALOG_COLORS dlg_color_table[];
> >
> > Then we need to bump libdialog's so version to 10?=A0 (I don't
> > think libdialog has symbol versioning)
> >
> > --
> > John Baldwin
>=20
> It does not have symbol versionning and yes good catch it needs to be bum=
ped

Upstream does do symbol versioning, but I don't know that can help,
(it doesn't appear to have some way of saying "version >=3D whatever",
but only "version =3D=3D whatever").

The soname should be updated (which is what you're talking about "bumped")

--=20
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEGYgtkt2kxADCLA1WzCr0RyFnvgMFAmFzRKEACgkQzCr0RyFn
vgM+CQwAgaKZPavUQYdLvsI7mPi7oWYultJSMO1LCRsxR62gERuWRsCgSyoVdL4b
q/JvFs35nc/x4aGRcmCXKmzGucqKtFiNArGbqwe0mumUUi0p+Vs5mjkD4ctJj0ju
MKG3EDVx5cTUcMV1Gzyw46x2eTJaQqZz7/hTDMhzAFRAXdEhOIZOdvROnaQ0Z+Me
TFN2ietFRSnYFnJV1UH6HHcsUH5+moPw+oRWnblK7q2+P5Lm4IwTZgNMaTwZOW+x
iSFCfPz//r6kV/1IP1xqvL2m3muD8TZD9q3s4/fMRdx/nhXlKBi9tWcmaZCTcjo/
fJZ8lZlae4Ibo7PUTadoq2ALxa3BjhD+me3ryg8YUEWIt21nEbg+B+6MwYmHIUFd
HoGsFR72TVBGTtke6FZJP44dz9U9bwJ+kcJmEUW5Y7YuIK0JlAqcsryDO+caEJgv
pDUouUHHBxYHw3xEEAVAW4flG7dfFnOT0NZWbOddb8zP3bP2dR3G/Tt9XHlx6csg
ZVJoUznK
=olbe
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211022230925.GA17806>