Date: Fri, 22 Dec 2000 23:30:45 -0800 (PST) From: Matthew Jacob <mjacob@feral.com> To: Assar Westerlund <assar@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: is it possible to have a NULL procp for an NFS request? Message-ID: <Pine.BSF.4.21.0012222323430.74029-100000@beppo.feral.com> In-Reply-To: <5lelyzsmht.fsf@assaris.sics.se>
next in thread | previous in thread | raw e-mail | index | archive | help
Hmm. The client wasn't following symlinks. The patch seems
simple enough, but it probably shouldn't just swallow the
error.
It looks like the last phk simplification lost some of the
functionality of the previous code- that I can fix.
On 23 Dec 2000, Assar Westerlund wrote:
> Matthew Jacob <mjacob@feral.com> writes:
> > I had a panic just now:
> >
> > db> t
> > tprintf() at tprintf+0x7c
> > nfs_msg() at nfs_msg+0x28
> > nfs_timer() at nfs_timer+0x1fc
> > softclock() at softclock+0x4f4
> > sithd_loop() at sithd_loop+0x18c
> > exception_return() at exception_return
>
> Yes, this is possible, (at least) when following symbolic links. This
> was discussed here on -current some time ago and I proposed the
> appended simple patch, but I didn't get any feedback on it.
>
> /assar
>
> Index: nfs_socket.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/nfs/nfs_socket.c,v
> retrieving revision 1.62
> diff -u -w -u -w -r1.62 nfs_socket.c
> --- nfs_socket.c 2000/11/26 20:35:21 1.62
> +++ nfs_socket.c 2000/12/23 05:59:51
> @@ -1969,6 +1969,7 @@
> char *server, *msg;
> {
>
> + if (p != NULL)
> tprintf(p, LOG_INFO, "nfs server %s: %s\n", server, msg);
> return (0);
> }
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0012222323430.74029-100000>