Date: Sat, 5 Dec 2020 21:18:28 +0000 (UTC) From: Baptiste Daroussin <bapt@FreeBSD.org> To: Yuri Pankov <yuripv@yuripv.dev> Cc: Thomas Munro <thomas.munro@gmail.com>, hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data Message-ID: <aad9a8d7-eaec-491d-a4bd-c74bfc297e1f@FreeBSD.org> In-Reply-To: <6b967ee3-5fc1-51cb-2cbf-8f5f4b3e0120@yuripv.dev> References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com> <5b8f1016-bcb3-42ff-9e70-c4c0240ea685@FreeBSD.org> <6b967ee3-5fc1-51cb-2cbf-8f5f4b3e0120@yuripv.dev>
next in thread | previous in thread | raw e-mail | index | archive | help
5 d=C3=A9c. 2020 22:13:31 Yuri Pankov <yuripv@yuripv.dev>:
> Baptiste Daroussin wrote:
>> 5 d=C3=A9c. 2020 02:25:29 Thomas Munro <thomas.munro@gmail.com>:
>> On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt@freebsd.org> wro=
te:
>>>> I do like what I see here, the only reason I haven't review is that I =
can't
>>>> test, since the last modification from hrs@ in the locale generation t=
ools each
>>>> time I try to regenerate the locales it fails.
>>>
>>> During install?=C2=A0 I noticed that too but wasn't sure of the correct=
fix, perhaps:
>>>
>>> diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
>>> index 76fff6acb17..b6ae2feadac 100644
>>> --- a/tools/tools/locale/Makefile
>>> +++ b/tools/tools/locale/Makefile
>>> @@ -95,7 +95,7 @@ install: install-${t}
>>> install-${t}:
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cd ${LOCALESRCDIR}/${t} && \
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rm -=
f Makefile *.src && \
>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -=
c ${t}/* ${LOCALESRCDIR}/${t}
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 install -=
c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
>>> .=C2=A0 endif
>>> .endfor
>>
>> Nope that one was easy to figure out, but once the locales are regenerat=
ed, localdef dies on plenty of them (non unicode mostly).
>
> Now that you mentioned it, there's something I was thinking about for a l=
ong time now -- it's probably a sign that we need to mark all single-byte l=
ocales as set in stone, and stop regenerating the source for them as well a=
s adding more and more workarounds against utf-8 charmap.=C2=A0 This is som=
ething I'm going to look into eventually as I believe it will make updating=
to new CLDR releases much easier, that is, if I'm not missing something he=
re.
>
I fully agree!!!
Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aad9a8d7-eaec-491d-a4bd-c74bfc297e1f>