Date: Thu, 03 Mar 2022 18:32:08 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Santiago Martinez <sm@codenetworks.net> Cc: Zhenlei Huang <zlei.huang@gmail.com>, freebsd-net@freebsd.org Subject: Re: Current with RSS and EPAIR and without INET6. Message-ID: <D5F573BA-B2B4-4EFA-BA00-60470ECA8BD2@FreeBSD.org> In-Reply-To: <7f1b3db6-07e0-8919-072f-cc764194814c@codenetworks.net> References: <0687A548-41D3-4D84-A83B-B2C0A87056BC@gmail.com> <E12FF030-E12E-442C-8675-59979CEE59D3@codenetworks.net> <9AC37B44-217F-4FE3-BAB3-482330F533AF@FreeBSD.org> <19c46030-0618-721a-7947-54142f50a943@codenetworks.net> <7f1b3db6-07e0-8919-072f-cc764194814c@codenetworks.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks!
Pushed as 52bcdc5b809ea56cbdce0bd36499e4ae74780d2b.
Kristof
On 2 Mar 2022, at 23:24, Santiago Martinez wrote:
> Hi Kristof and Zhenlei,
>
> I have updated the patch as requested (wrapped the ifdef INET|INET6 inside the ifdef RSS).
>
> It now works without INET6 or without INET. (only tested module loading and interface creation on both cases v4/6).
>
> Best regards.
>
> Santi
>
> @@ -73,8 +73,12 @@__FBSDID("$FreeBSD$");
> #include <net/netisr.h>
> #ifdef RSS
> #include <net/rss_config.h>
> +#ifdef INET
> #include <netinet/in_rss.h>
> +#endif
> +#ifdef INET6
> #include <netinet6/in6_rss.h>
> +#endif
> #endif
> #include <net/vnet.h>
>
> @@ -217,12 +221,16 @@epair_menq(struct mbuf *m, struct epair_softc *osc)
> eh = mtod(m, struct ether_header *);
>
> switch (ntohs(eh->ether_type)) {
> +#ifdef INET
> case ETHERTYPE_IP:
> rss_soft_m2cpuid_v4(m, 0, &bucket);
> break;
> +#endif
> +#ifdef INET6
> case ETHERTYPE_IPV6:
> rss_soft_m2cpuid_v6(m, 0, &bucket);
> break;
> +#endif
> default:
> bucket = 0;
> break;
>
>
>
>
> On 3/2/22 20:12, Santiago Martinez wrote:
>> Hi Kristof, sorry for my late reply. Im testing without INET.
>>
>> I will keep you updated.
>>
>> Santi
>>
>>
>> On 2/28/22 21:20, Kristof Provost wrote:
>>> On 28 Feb 2022, at 21:16, Santiago Martinez wrote:
>>>> Hi there , yes good point , the first ifdef should go inside the RSS ifdef . Will modify it to also work with INET6 only. Thanks for the feedback.
>>>> Santi
>>>>
>>>>
>>> Can you copy me on your updated patch? I’ll commit that.
>>>
>>> Thanks for finding and reporting this.
>>>
>>> Kristof
>>>
>>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D5F573BA-B2B4-4EFA-BA00-60470ECA8BD2>