Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jun 2016 00:09:42 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Rodrigo OSORIO <rodrigo@freebsd.org>
Cc:        freebsd-ports@freebsd.org
Subject:   Re: pkg SAT_SOLVER bugs
Message-ID:  <20160627220942.gy7t3klnswmukz6q@ivaldir.etoilebsd.net>
In-Reply-To: <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org>
References:  <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--tgtwzxc5dak6i2b5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 27, 2016 at 11:42:08PM +0200, Rodrigo OSORIO wrote:
> On 06/27/16 12:38, Hans Petter Selasky wrote:
> > Hi,
> >=20
> > I found some bugs in PKG with regard to the SAT_SOLVER environment
> > variable. Please find patch attached :-)
> >=20
> > Issues fixed:
> > 1) No need to use hash table when generating SAT rules for external
> > solver. Variables are already in a linear array. Fix encoding and
> > decoding of SAT data.
> > 2) Endless variable loop caused pkg to crash.
> > 3) it->inverse was checked for non-zero, while it should actually be
> > checked for -1 only. SAT rules produces were all negative.
> >=20
> > How to verify:
> >=20
> > make -C /usr/ports/math/picosat all install clean
> >=20
> > env SAT_SOLVER=3Dpicosat pkg upgrade
> >=20
> > --HPS
> >=20
> >=20
> > _______________________________________________
> > freebsd-ports@freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
> >=20
>=20
> Thanks! this patch saves my day, I was stuck reinstalling a computer in
> current, and after few rounds using pkg the solver start complaining and
> pretending missing packages was yet installed.
>=20
> I apply you patch on top of the last version in ports and the patch work =
as
> a charm. I'll keep testing it until a new version comes.
>=20
> regards,
> - rodrigo

that is unrelated, what saved you it that building from ports you switched =
form
1.8.5 to 1.8.6 his patch is to solve the use of an external SAT solver whic=
h I
admit I haven't tested for a while.

Pkg 1.8.6 is the default binary package for all release but head right now,
pending for the next build cycle.

Best regards,
Bapt

--tgtwzxc5dak6i2b5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXcaQPAAoJEGOJi9zxtz5a4okQAIezpNF2tRVdWZTbWMlPvYI0
YTPGAryJXCq5ueaxaOlVX/hfHn88hTwuJBs3q1HvKSkvtzOzu1nq4H8zk+NIa2vc
CGw4uMwiqFEWwHa1NceRPd896lI+cSQRqY5qWosO1LF+u4104DjaZXUhodbmD6Dm
aCE74JWDhiwMINF6EydAA1OQruvgU3HOFzOD8Nq1sQ1jTPn5Rs3GzjlF8uAg0Bqm
zO7FRA/tvUOacImJs8p5Ad0Z5eK9yWphNXAmAuR78cyw4WGRHILEzhbsYZnxpLSJ
3BT/5uJVKYUMC0r3Mm9p4dP6xtt+1TOFElbDmvv3evMci1LJVFkr+5PW3HsdVmcP
cSIelxqM+OWcpvz1ThBfT3NaXeRuWfW+eMuMRbv9gMn5oso85woqoWomxJ2xpKFg
BiU+yu1if7mNCrAseoYizs6t05mvgNqGXi/i2SzvQzVVihr43knRwQQeC/bBPDAS
mea5baHCHZq26dwi8ckclFhP18UnNFNYG5oCi5YgGCyLmaFpLK+XTY6L7VRE6m/W
ZbF+L5e5AKL/v4zFg9kv3Wk3J4WVU9WY9SLTta9vL9p+1ccNRQkuy8X0y2xiU+g/
ZbLdmBCSpoK8BRbBxTuSwwlELLjVDWBHtDGSkPnkPteTxiRl8sWiEmFebfNmeL2Y
7B8tohIl2cNGIDeAgDb3
=F1uG
-----END PGP SIGNATURE-----

--tgtwzxc5dak6i2b5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160627220942.gy7t3klnswmukz6q>