Date: Fri, 3 Feb 2017 14:00:26 +0100 From: Torsten Zuehlsdorff <tz@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports@FreeBSD.org, linimon@FreeBSD.org, "jim@ohlste.in >> Jim Ohlstein" <jim@ohlste.in> Subject: Re: Recent update to lang/php70 and lang/php71 Message-ID: <9d511b76-ee24-a916-b238-293339025d78@FreeBSD.org> In-Reply-To: <83055CCD-D150-4D1D-8F4E-A422E1F63D1A@adamw.org> References: <15b31c6c-52be-e04f-64bd-3dc5b8cb2332@ohlste.in> <023c7b00-7b06-796f-c091-446c61320222@FreeBSD.org> <8e109406-a056-9043-edc9-d36c92346a4f@ohlste.in> <6d56b335-44c8-5ddb-20c0-ce44ba208ae6@FreeBSD.org> <83055CCD-D150-4D1D-8F4E-A422E1F63D1A@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02.02.2017 18:21, Adam Weinberger wrote: >> On 2 Feb, 2017, at 7:39, Torsten Zuehlsdorff <tz@freebsd.org> wrote: >> >> On 02.02.2017 15:37, Jim Ohlstein wrote: >>> Hello, >>> >>> On 02/02/2017 04:35 AM, Torsten Zuehlsdorff wrote: >>>> Hello Jim, >>>> >>>>> Could not this semantic change have waited for a new version? It forced >>>>> a rebuild of ALL PHP extensions for no reason. They all had a dependency >>>>> on devel/pcre via the main port as it was. >>>> >>>> Did you use poudriere? >>> >>> Yes >>> >>>> >>>> It wasn't meant to force a rebuild. There was no PORTREVISION bump nor a >>>> new dependency. But poudriere detect a new one, so i would say its a >>>> poudriere bug. Or am i wrong? >>> >>> Looks like a direct dependency was added. Here's a sample output from a >>> jail that runs PHP70: >>> >>> Installed packages to be REINSTALLED: >>> [output] >> >> Yes, it look like, but it wasn't. That's the patch: >> https://svnweb.freebsd.org/ports/head/lang/php71/Makefile?r1=433046&r2=433045&pathrev=433046 <https://svnweb.freebsd.org/ports/head/lang/php71/Makefile?r1=433046&r2=433045&pathrev=433046>; >> >> Only one line was moved more upwards. Nothing more. This shouldn't have caused such a detection. > > > It’s not, though, because before it was protected within !defined(PKGNAMESUFFIX). Previously, only php itself brought in the pcre dependency; now all the extensions bring it in too. Thanks for pointing to this. I reverted the patch. Greetings, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9d511b76-ee24-a916-b238-293339025d78>