Date: Sat, 25 Feb 2012 19:48:18 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Mikolaj Golub <trociny@freebsd.org> Cc: "Robert N. M. Watson" <rwatson@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) Message-ID: <20120225174818.GC55074@deviant.kiev.zoral.com.ua> In-Reply-To: <86d393dvqr.fsf@kopusha.home.net> References: <CAOnPXZ_y5G6uEBWmfuH7qYBh%2B4Pw=O91ztCPEFCOTzWdCzx%2BRA@mail.gmail.com> <BBDE763A-F55E-453D-A503-2489C9040EF6@freebsd.org> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> <86ehtrf8qf.fsf@kopusha.home.net> <20120219170151.GS3283@deviant.kiev.zoral.com.ua> <86d393dvqr.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--KdsnslqZnlo4hNtV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 25, 2012 at 12:59:24PM +0200, Mikolaj Golub wrote: >=20 > On Sun, 19 Feb 2012 19:01:51 +0200 Konstantin Belousov wrote: >=20 > KB> On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote: > >>=20 > >> On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote: > >>=20 > >> KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote: > >> >> After collecting all suggestions and additional testing I have go= t this patch > >> >> set: > >> >>=20 > >> >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch > >> KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the pro= totype > >> KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim. > >>=20 > >> Done. > >>=20 > >> >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > >> >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch > >> KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH = etc, > >> KB> otherwise it takes too much reading to understand that it is not= undetach. > >>=20 > >> Unfortunately, vnode_if.awk does not support underscores in VOP names= . It > >> failed with "Invalid %% construction" due to the restriction: $2 !~ /= ^[a-z]+$/. > >> So I reverted back to the old naming. > KB> Ok, might be it makes sense to try to add underscore to the set of > KB> allowed symbols. >=20 > >>=20 > >> The updated patches: > >>=20 > >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch > >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > >> http://people.freebsd.org/~trociny/VOP_UNP.4.patch >=20 > KB> In the comment above vfs_unp_reclaim(), say "before socket-type vnode > KB> reclamation". >=20 > KB> I have no further comments. >=20 > I have committed all preparation patches and going to commit the VOP_UNP_* > bits. The latest version: >=20 > http://people.freebsd.org/~trociny/VOP_UNP.6.patch >=20 > (in this version I added a note to UPDATING). Ok. >=20 > I am thinking now about 'MFC after'. Thanks to jhb's spare vops it looks = like > it is possible to merge it in stable/9 without breaking the KBI, but then= I > will consume 3 of 5 available spare vops. So is it worth doing? I do not think that we shall be so restrained on the use of spare VOPs. --KdsnslqZnlo4hNtV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9JHuIACgkQC3+MBN1Mb4ix9QCfYo5dPvO7xhCXCCPwq89miWYX SwQAn2vKifyWasEIR4E8zmD5lb7F4voM =5vZu -----END PGP SIGNATURE----- --KdsnslqZnlo4hNtV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120225174818.GC55074>