Date: Thu, 4 Sep 2008 17:41:38 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: freebsd-hackers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: Creation of the NO_SSP build knob Message-ID: <20080904154138.GM72107@obiwan.tataz.chchile.org> In-Reply-To: <86hc8w55mr.fsf@ds4.des.no> References: <20080904124653.GK72107@obiwan.tataz.chchile.org> <20080904135200.GC31289@alpha.local> <86ljy857zz.fsf@ds4.des.no> <20080904141705.GL72107@obiwan.tataz.chchile.org> <86hc8w55mr.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 04, 2008 at 04:48:28PM +0200, Dag-Erling Smørgrav wrote:
> bsd.own.mk:
>
> 184 #
> 185 # Supported NO_* options (if defined, MK_* will be forced to "no",
> 186 # regardless of user's setting).
> 187 #
> 188 .for var in \
> 189 INSTALLLIB \
> 190 MAN \
> 191 PROFILE
> 192 .if defined(NO_${var})
> 193 WITHOUT_${var}=
> 194 .endif
> 195 .endfor
Ok, thank you Dag-Erling. I didn't understand what you meant the first
time.
If SSP belongs to this list, then NO_SSP is an alias for WITHOUT_SSP.
But it will still not be possible to use WITH_SSP in src.conf or
command-line.
Does this mean that enforcing the default values with knobs is not
supported? Or put differently, is it forbidden to use the opposite
knobs of those documented in src.conf(5)? bsd.own.mk has the following
test:
361 .if defined(WITH_${var}) && defined(WITHOUT_${var})
362 .error WITH_${var} and WITHOUT_${var} can't both be set.
363 .endif
So I would say that it is allowed to use WITH_SSP, even if it's the
default.
This can be a problem. Let's say a user has WITH_INFO= in src.conf for
some reason. If WITHOUT_INFO= is used somewhere in the source tree,
it will break with an error misleading for the user:
WITH_INFO and WITHOUT_INFO can't be both set.
Shouldn't we have a knob that overrides whatever the user says, only for
internal use in the source tree? That was my original intent when
asking if I could add NO_SSP.
Regards,
--
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080904154138.GM72107>