Date: Tue, 5 Oct 2010 09:47:36 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: hastd: assertion (res->hr_event != NULL) fails in secondary on split-brain Message-ID: <20101005074736.GM7322@garage.freebsd.pl> In-Reply-To: <86tyl1m85y.fsf@zhuzha.ua1> References: <86hbh44wgl.fsf@kopusha.home.net> <86aamw4l42.fsf@kopusha.home.net> <20101004213647.GK7322@garage.freebsd.pl> <86tyl1m85y.fsf@zhuzha.ua1>
next in thread | previous in thread | raw e-mail | index | archive | help
--SgT04PEqo/+yUDw3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2010 at 10:05:13AM +0300, Mikolaj Golub wrote: >=20 > On Mon, 4 Oct 2010 23:36:47 +0200 Pawel Jakub Dawidek wrote: >=20 > PJD> I see three problems:) >=20 > PJD> 1. In child_kill() you interpret status value always, even if it is > PJD> invalid due to earlier errors. > PJD> 2. While copying the code you changed style. Don't you like style(9= )?:) >=20 > Me like :-). But it looks like my emacs don't. Need to teach it somehow... >=20 > PJD> 3. The patch doesn't fix the root cause of the problem. >=20 > Thank you for your comments. The hang you reported is still not fixed, but I'm working on it. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --SgT04PEqo/+yUDw3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyq2BgACgkQForvXbEpPzRkwgCZAaD9pxGIGoFhDA0U3H4yg4VP ZqQAnRlcqx9F8nPn3VD9+aBP+1rNwGc2 =ww4h -----END PGP SIGNATURE----- --SgT04PEqo/+yUDw3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101005074736.GM7322>