Date: Fri, 29 Sep 2017 03:56:48 +0300 From: Guy Yur <guyyur@gmail.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Ian Lepore <ian@freebsd.org>, Kurt Jaeger <lists@opsec.eu>, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: if_awg fixes Message-ID: <CAC67Hz_GVQROj31g=B_k5GPHNVkuRZHxFZSrgYVc7HQ_hB%2B8KQ@mail.gmail.com> In-Reply-To: <8cd473c06a33c360db774a428a030833@megadrive.org> References: <CAC67Hz9GzTeKmBfiCsJj=_cC=63gzEeJ7VbwJss4xk_oNLbaDw@mail.gmail.com> <20170928011129.GC86601@home.opsec.eu> <1506561886.31939.16.camel@freebsd.org> <20170928105724.b76168c5065ebb388b056f51@bidouilliste.com> <CAC67Hz-LXR=d6tfqBa=6NDU10%2Bmk13b=r5Xbq%2BBjGXep-sckdA@mail.gmail.com> <8cd473c06a33c360db774a428a030833@megadrive.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 September 2017 at 22:13, Emmanuel Vadot <manu@bidouilliste.com> wrote: > On 2017-09-28 21:10, Guy Yur wrote: >> >> Hi, >> >> I created a phabricator account and four diffs. >> >> https://reviews.freebsd.org/D12535 >> https://reviews.freebsd.org/D12536 >> https://reviews.freebsd.org/D12537 >> https://reviews.freebsd.org/D12538 >> >> ... >> >> Thanks, >> Guy > > > Thanks a lot, I will not have time to look at them before next week. Will > probably look at them on monday. > > > -- > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org> Thanks. I updated D12537. It appears that tx interrupt should only be requested on the last segment otherwise the card won't issue it. In a scenario where every 64th frame is not the last segment of a frame there will never be a tx interrupt triggered. My changes included only doing tx drain on TX_INT while original code also drains on TX_BUF_UA_INT. So no TX_INTs issued lead to full queue never clearing. Without my changes tx queue won't be stuck but drain will need to run on the full queue in the above scenario not just the last 64 buffers. if_vr has the same behavior of setting the flag only on last segment. Seems stable so far with ssh on constant output loop. Also added review for draining tx buffers and clearing rx buffers on stop. https://reviews.freebsd.org/D12539 -- Guy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAC67Hz_GVQROj31g=B_k5GPHNVkuRZHxFZSrgYVc7HQ_hB%2B8KQ>