Date: Thu, 6 Oct 2016 10:39:56 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Michael Gmelin <grembo@FreeBSD.org> Cc: FreeBSD Current <freebsd-current@FreeBSD.org> Subject: Re: [request for testing] isl, cyapa on chromebooks Message-ID: <decbe48c-ba49-3a21-b18c-ffb2d93eb0a3@FreeBSD.org> In-Reply-To: <8ed7a632-6839-52b8-6a7a-68c661f67819@FreeBSD.org> References: <1e66fc64-cdff-e94b-4b0c-55cb05e2b5a1@FreeBSD.org> <20161003180750.744dae0a@bsd64.grem.de> <ecd26145-442d-d059-59a1-139e206d451b@FreeBSD.org> <20161003222528.56d46787@bsd64.grem.de> <c1a5224f-6cef-ed9c-d795-6af3d93dc48d@FreeBSD.org> <20161004114635.64857a29@bsd64.grem.de> <d989c916-e705-ca6b-9ea6-ccc17c785a82@FreeBSD.org> <20161005004831.2a2fdc4b@bsd64.grem.de> <1bcfd282-63fd-f8ee-4dad-393b51f14bcd@FreeBSD.org> <302FDA6E-DEC7-49F0-8F2C-8C26C8A884AF@freebsd.org> <53bca4d2-975f-f4a0-d12a-5d73fba01a0c@FreeBSD.org> <3B8B4A4A-8583-4063-999A-780DD5867E04@freebsd.org> <8ed7a632-6839-52b8-6a7a-68c661f67819@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/10/2016 10:25, Andriy Gapon wrote: > On 06/10/2016 10:08, Michael Gmelin wrote: >> >> >>> On 05 Oct 2016, at 15:01, Andriy Gapon <avg@FreeBSD.org> wrote: >>> >>>> On 05/10/2016 14:19, Michael Gmelin wrote: >>>> >>>> ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and >>>> iicbus_attach are not. >>> >>> Thank you! >>> Now I think I see where I made a silly mistake. >>> Please try an updated version of the patch from here >>> https://people.freebsd.org/~avg/ig4-i2c.v3.diff >>> It contains a fix and some cosmetic changes on top of the previous patch. >>> >> >> Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all inputs, like dev.isl.ir etc, are stuck at 0). > > At least some progress... > Anything interesting in logs? > > Oh! and I've just spotted a typo in isl.c: the last call to isl_read_byte() in > isl_read_sensor() should have REG_DATA2 (not REG_DATA1 again). And another, more severe typo :-( In isl_read_byte we should pass both messages to the bus: return (iicbus_transfer(dev, msgs, 2)); That is, s/1/2/. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?decbe48c-ba49-3a21-b18c-ffb2d93eb0a3>