Date: Mon, 15 Sep 2014 07:54:53 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, Garrett Cooper <ngie@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org> Subject: Re: svn commit: r271574 - user/ngie/add-pjdfstest/contrib/pjdfstest Message-ID: <20140915074551.B6416@besplex.bde.org> In-Reply-To: <916E2311-C6BF-423E-A149-3F1853584020@gmail.com> References: <201409140909.s8E99ncV087445@svn.freebsd.org> <20140914200428.P1559@besplex.bde.org> <916E2311-C6BF-423E-A149-3F1853584020@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 14 Sep 2014, Garrett Cooper wrote: > >> On Sep 14, 2014, at 4:21, Bruce Evans <brde@optusnet.com.au> wrote: >> >>> On Sun, 14 Sep 2014, Garrett Cooper wrote: >>> >>> Log: >>> Redo r271374 by using the right typecast for comparing i and ngroups >> >> It is still quite broken (more broken than without the cast, since the >> cast breaks the warning). > I completely agree with your concerns. Since this is "contrib" code I wanted to make the smallest set of changes to make things compile, then push for the proper fix upstream. OK. > As an aside, is u_int completely portable; I personally prefer the longer forms of non-fixed width types, e.g. unsigned int, but that's my personal preference. It is unportable. It shouldn't be used at all in contrib'ed code, but I thought that pjd worked here :-). I think BSD is a BSDism, but using it is even more natural now than uintN_t is standard (except that matches the SysVism uint better). Bruce Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140915074551.B6416>