Date: Thu, 18 Oct 2018 23:52:10 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: Re: embed endian info in locale data files magic (PR231965) Message-ID: <feb7f5ab-9818-72f1-98a1-848112d6c4ec@yuripv.net> In-Reply-To: <92614.1539843385@critter.freebsd.dk> References: <f081ab81-56d0-49cc-92b0-fadc09618d31@yuripv.net> <abaa1192-defc-973e-8d0f-b8e5a2437c0d@yuripv.net> <CANCZdfpuUhJTxeUrEn1jrphSVaPqWw86Xm-e-rdX_mwC_kJO9w@mail.gmail.com> <92614.1539843385@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tF7bYPLEyp2hmgWJvyuc0MfyDwEogvTGq Content-Type: multipart/mixed; boundary="zeVC69HDKDu7ivzgLoHj1A0PJ4E0nGZsv"; protected-headers="v1" From: Yuri Pankov <yuripv@yuripv.net> To: freebsd-hackers <freebsd-hackers@freebsd.org> Message-ID: <feb7f5ab-9818-72f1-98a1-848112d6c4ec@yuripv.net> Subject: Re: embed endian info in locale data files magic (PR231965) References: <f081ab81-56d0-49cc-92b0-fadc09618d31@yuripv.net> <abaa1192-defc-973e-8d0f-b8e5a2437c0d@yuripv.net> <CANCZdfpuUhJTxeUrEn1jrphSVaPqWw86Xm-e-rdX_mwC_kJO9w@mail.gmail.com> <92614.1539843385@critter.freebsd.dk> In-Reply-To: <92614.1539843385@critter.freebsd.dk> --zeVC69HDKDu7ivzgLoHj1A0PJ4E0nGZsv Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Poul-Henning Kamp wrote: > -------- > In message <CANCZdfpuUhJTxeUrEn1jrphSVaPqWw86Xm-e-rdX_mwC_kJO9w@mail.gm= ail.com> > , Warner Losh writes: >=20 >>> 3. Always store the data in LE (or BE, doesn't matter), and >>> appropriately convert while reading. This will likely require least >>> change. >> >> I like this. >=20 > The locale stuff can have a surprisingly large performance impact, so > it might be a good idea to run some benchmarks first. Thanks for the answers, and especially for mentioning the magic word which is "performance" that I seem to be forgetting about. I have updated the change to skip any runtime conversions and rather make localedef output data in target system's byte order. If anyone wants to take a look, it's still at: https://reviews.freebsd.org/D17603 --zeVC69HDKDu7ivzgLoHj1A0PJ4E0nGZsv-- --tF7bYPLEyp2hmgWJvyuc0MfyDwEogvTGq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlvI8noACgkQk4vgf7Eq 4WzMXwgAsxqXQsV+G+JzF9kM65lTkbZAg16/MwKJtVPhDGgqmK1v0VIIwL/Malyq GRaMtsWRZB2wBLiffj3X6vOwTrTEHcTmHDpB8eWG4dFicM6Owt3Mh5NXp4+VD2wy 2EPgM8deLgeSKVQ9mSXk9vqiu2FQfQoXHR12erlSrzcfa6iudbAQcBtkhKBjKiRx dVIdimfFGjQcaAZxX0EfV9GcRbd4T+HGRb0LXkldNK4LJYw5954YS59Hp1qMgtWB i5pezQdjnMPtCJegYenw8j5Fpkp9ZjFDxdFGIkTNMOr+14vBTZ0AhQi2TTjcBEN/ xvRD3yndMLE9uiKmxjdgek46hcSvxQ== =r82M -----END PGP SIGNATURE----- --tF7bYPLEyp2hmgWJvyuc0MfyDwEogvTGq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?feb7f5ab-9818-72f1-98a1-848112d6c4ec>