Date: Fri, 26 May 2000 13:18:04 -0700 From: Mike Smith <msmith@freebsd.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Mike Smith <msmith@FreeBSD.ORG>, FreeBSD-current <current@FreeBSD.ORG> Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.c src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ... Message-ID: <200005262018.NAA00847@mass.cdrom.com> In-Reply-To: Your message of "Fri, 26 May 2000 08:38:20 %2B0200." <9833.959323100@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
> In message <200005252326.QAA02413@mass.cdrom.com>, Mike Smith writes: > >> >I objected to a recent commit hiding the fact that this is > >> >"(elm)->field.sle_next". Anyway, curelm must be a pointer to a struct. > >> >Not just any struct; the struct must contain a "field" declared using > >> >SLIST_ENTRY(). > >> > >> It could be an union or class as well... > > > >It would not be very useful if it were a union; the class issue is valid > >(although you could trivially use a struct contained within a class and a > >parent reference) but definitely not a good enough argument to support > >the massive breakage this otherwise entails. > > I have yet to see any signs of "massive breakage". Try "source-level incompatibility with everyone else that uses these interfaces" (eg. all the other BSDs, OS/X, AIX, etc.) The queue macros are a stable, widely-used API. If you're going to change their calling conventions, simple commonsense behooves you to rename them as well. -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005262018.NAA00847>