Date: Thu, 30 May 2013 09:56:14 -0400 From: Mark Johnston <markj@freebsd.org> To: George Neville-Neil <gnn@freebsd.org> Cc: rstone@freebsd.org, freebsd-dtrace@freebsd.org Subject: Re: adding SDT probe functions with 6+ DTrace arguments Message-ID: <20130530135601.GA1631@gloom.sandvine.com> In-Reply-To: <9900CFFB-6E68-4034-805A-859A937179EF@freebsd.org> References: <20130530040705.GA40320@gloom> <CALWP=0aRG5zjcNBJsgA0gwp9x8J_gxEtagfVy3JfK2ePC0J0jA@mail.gmail.com> <CA%2BXzFFjOE7y4QueSuqw8zcWMWk7pVyGKifZwgbZcANXYpKrVyA@mail.gmail.com> <9900CFFB-6E68-4034-805A-859A937179EF@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 30, 2013 at 09:02:54AM -0400, George Neville-Neil wrote:
>
> On May 30, 2013, at 2:14 , Brendan Gregg <brendan.gregg@joyent.com> wrote:
>
> > G'Day Mark,
> >
> > As this might be interesting: to check that DTRACE_PROBE7 worked, in
> > Solaris I had added an sdt:::test probe, which could be invoked by the
> > DTrace test suite (sdt/tst.sdtargs.c) by calling uadmin() with A_SDTTEST:
> >
> > case A_SDTTEST:
> > {
> > DTRACE_PROBE7(test, int, 1, int, 2, int, 3, int, 4, int, 5,
> > int, 6, int, 7);
> > break;
> > }
> >
> > Getting the tcp and ip providers working will be great.
> >
>
> Chiming in late. Yes, let's extend the SDT macros in line with what we've done
> already. This will also make it easy to MFC to 9 and 8.
Ok, thanks. I'll commit them later today. The network providers depend
on them, so I wanted to get them in first as well as fix the bugs
mentioned in my other email on this thread.
-Mark
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130530135601.GA1631>