Date: Wed, 25 Feb 2009 20:50:02 +0100 From: Max Laier <max@love2party.net> To: Artis Caune <artis.caune@gmail.com> Cc: samm@os2.kiev.ua, freebsd-pf@freebsd.org Subject: Re: openbsd spamd is leaking memory? Message-ID: <200902252050.02682.max@love2party.net> In-Reply-To: <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com> References: <9e20d71e0902250435y6e090fb0rc138233242fe7d60@mail.gmail.com> <200902251442.43794.max@love2party.net> <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 25 February 2009 15:10:04 Artis Caune wrote: > 2009/2/25 Max Laier <max@love2party.net>: > > Hello Artis, > > > > looks like a valid catch to me. I'm CC'ing the upstream maintainer (Bob, > > that's you, right?) From a quick glance there is also a minor leak in > > readsuffixlists in the goto bad case. Bob Beck has meanwhile committed the slightly more encompassing fix which can be obtained via webcvs: http://www.openbsd.org/cgi- bin/cvsweb/src/libexec/spamd/grey.c.diff?r1=1.45;r2=1.46 Alex, do you have time to roll a new release or would you prefer the patch applied via the ports patch facilities? > I'm running spamd with this patch more than 2h and no leaks :) > > > > --- grey.c.orig 2008-12-07 23:12:52.000000000 +0200 > +++ grey.c 2009-02-25 15:22:48.000000000 +0200 > @@ -512,7 +512,8 @@ > dbc->act = 0; > dbc->dsiz = 0; > SLIST_REMOVE_HEAD(&db_changes, entry); > - > + free(dbc); > + dbc = NULL; > } > return(ret); > } -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902252050.02682.max>