Date: Sun, 9 Aug 2015 19:48:22 +0200 From: Ed Schouten <ed@nuxi.nl> To: David Chisnall <theraven@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r286521 - projects/collation/lib/libc/locale Message-ID: <CABh_MK=WatSc1XObzNyeTq-QAbr%2B=Lw3JDgQrxhOBX8SeYd1fg@mail.gmail.com> In-Reply-To: <A7DDA029-A520-41E7-B4EA-CD5DB4B5023D@FreeBSD.org> References: <201508091150.t79Boo3v096088@repo.freebsd.org> <20150809223647.O2415@besplex.bde.org> <20150809163935.GA96980@ivaldir.etoilebsd.net> <A7DDA029-A520-41E7-B4EA-CD5DB4B5023D@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2015-08-09 19:02 GMT+02:00 David Chisnall <theraven@freebsd.org>: > As I said in the code review, when we=E2=80=99re doing a printf and some = file I/O, the cost of a short-lived heap allocation is likely to be in the = noise. Exactly. Furthermore, it isn't required that implementations define PATH_MAX. The maximum pathname length is not necessarily fixed. I personally prefer calling malloc() instead of silently truncating strings. --=20 Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK/VAT number: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MK=WatSc1XObzNyeTq-QAbr%2B=Lw3JDgQrxhOBX8SeYd1fg>