Date: Tue, 13 Jul 2010 18:28:39 -0400 From: Sahil Tandon <sahil@FreeBSD.org> To: freebsd-ports@freebsd.org Cc: itetcu@FreeBSD.org Subject: Re: dspam install Message-ID: <20100713222839.GA19319@magic.hamla.org> In-Reply-To: <AANLkTikSxrIkpzB-cFiGCwOrggv6-4qp-vgIw08HIIQa@mail.gmail.com> References: <4C3A2EE7.7020104@paz.bz> <20100711212831.GA17226@magic.hamla.org> <AANLkTikNzfsunMHILOG6oUgJqPQLu9AZQWX0t50HxxRH@mail.gmail.com> <20100712230428.GB18432@magic.hamla.org> <AANLkTikSxrIkpzB-cFiGCwOrggv6-4qp-vgIw08HIIQa@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[mail/dspam maintainer Cc:'d]
On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote:
> 2010/7/13 Sahil Tandon <sahil@freebsd.org>:
> > On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote:
> >
> >> .if defined(WITH_MYSQL)
> >> WANT_MYSQL_VER=3D 55 ...
> >> .endif
> >>
> >> Then if the user wants a different version he still can change using=
:
> >> WITH_MYSQL_VER=3D 44.
> >
> > That change by itself will not work because in bsd.database.mk:
> >
> > =A0.if defined(WITH_MYSQL_VER) && ${WITH_MYSQL_VER} !=3D ${WANT_MYSQL=
_VER}
> > =A0IGNORE=3D ...
>=20
> Then, explain me why do both php5 and php5-pgsql have not
> KNOBS/OPTIONS like dspam and work with this variable WITH_PGSQL_VER ?
This is a good opportunity for you to learn about how the ports system
works. Compare the contents of both ports and also review
bsd.database.mk; if, after that, you still do not understand the current
behavior, let us know.
> Because I meant, if someone made these KNOBS, that's would suppose
> they should be used. As shown just above it works with php5-pgsql.
>=20
> So if a variable could be used to specify a specific version, it must
> be used instead of a couple of option that set the package version. I
> think WITH_MYSQL_VER and WITH_PGSQL_VER were made for that. (There is
> one for apache too)
I appreciate your frustration, but please realize that there are often
many ways to accomplish the same task. Trade-offs are involved. If you
believe a port can be improved, please (and now I'm repeating myself)
submit a patch! If you are unable to create a patch, then clearly
explain your idea in pseudo-code and submit it as a PR for the
maintainer's consideration. If you have trouble creating a patch, also
feel free to ping me off-list; I'm happy to work with you on this.
> >> We must make a big KISS cleanup in the ports tree to make it as good
> >> as NetBSD' pkgsrc.
> >
> > Please send PRs or provide specific details; general comments like th=
e
> > above are not helpful.
>=20
> Yes sometime I'm nasty with people, I'm sorry about that but when I
> saw this port I just didn't understand.
What did you not understand?
> I apologize for my english.
No apology needed, as that is not the problem here.
--=20
Sahil Tandon <sahil@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100713222839.GA19319>