Date: Mon, 21 Feb 2011 21:39:09 -0800 From: Artem Belevich <fbsdlist@src.cx> To: "Jayachandran C." <c.jayachandran@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: lib/libc/mips/string/bzero.S -- problem in 64-bit mode. Message-ID: <AANLkTin7%2Bf5v6fBX-TeMt=BxrH_3r1Qb_Y_y=HJ08Z=K@mail.gmail.com> In-Reply-To: <AANLkTim83G00D_xw1tyK8qyVwOWL6-_ivpt-zDOoe3-U@mail.gmail.com> References: <AANLkTik2evgf4-k85P%2Bsm953ofa0=UNd7o2uWhQw7qiB@mail.gmail.com> <AANLkTim83G00D_xw1tyK8qyVwOWL6-_ivpt-zDOoe3-U@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00163630fe5544b6a5049cd8662e Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable > I just tested this with a simple program - and there is certainly an > issue here. =A0If you can send me a patch, I can check that in after > testing. Try attached diff. > The kernel version of bzero() does not seem to have the SZREG=3D=3D8 case= , > and this bug. True. It still uses 32-bit sw to zero stuff out. There are number of routines in the kernel that could take advantage of 64-bit instructions. --Artem --00163630fe5544b6a5049cd8662e Content-Type: application/octet-stream; name="bzero.diff" Content-Disposition: attachment; filename="bzero.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gkgdtiph0 ZGlmZiAtLWdpdCBhL2xpYi9saWJjL21pcHMvc3RyaW5nL2J6ZXJvLlMgYi9saWIvbGliYy9taXBz L3N0cmluZy9iemVyby5TCmluZGV4IDY2ZjI5ZGQuLjgzZTU0YmEgMTAwNjQ0Ci0tLSBhL2xpYi9s aWJjL21pcHMvc3RyaW5nL2J6ZXJvLlMKKysrIGIvbGliL2xpYmMvbWlwcy9zdHJpbmcvYnplcm8u UwpAQCAtNTgsMjcgKzU4LDkgQEAgTEVBRihiemVybykKIAlQVFJfU1VCVQlhMywgemVybywgYTAJ IyBjb21wdXRlICMgYnl0ZXMgdG8gd29yZCBhbGlnbiBhZGRyZXNzCiAJYW5kCQlhMywgYTMsIFNa UkVHLTEKIAliZXEJCWEzLCB6ZXJvLCAxZgkjIHNraXAgaWYgd29yZCBhbGlnbmVkCi0jaWYgU1pS RUcgPT0gNAogCVBUUl9TVUJVCWExLCBhMSwgYTMJIyBzdWJ0cmFjdCBmcm9tIHJlbWFpbmluZyBj b3VudAotCVNXSEkJCXplcm8sIDAoYTApCSMgY2xlYXIgMSwgMiwgb3IgMyBieXRlcyB0byBhbGln bgorCVJFR19TSEkJCXplcm8sIDAoYTApCSMgY2xlYXIgMSwgMiwgb3IgMyBieXRlcyB0byBhbGln bgogCVBUUl9BRERVCWEwLCBhMCwgYTMKLSNlbmRpZgotI2lmIFNaUkVHID09IDgKLQlQVFJfU1VC VQlhMSwgYTEsIGEzCSMgc3VidHJhY3QgZnJvbSByZW1haW5pbmcgY291bnQKLQlQVFJfQUREVQlh MCwgYTAsIGEzCSMgYWxpZ24gZHN0IHRvIG5leHQgd29yZAotCXNsbAkJYTMsIGEzLCAzCSMgYml0 cyB0byBieXRlcwotCWxpCQlhMiwgLTEJCSMgbWFrZSBhIG1hc2sKLSNpZiBfQllURV9PUkRFUiA9 PSBfQklHX0VORElBTgotCVJFR19TUkxWCWEyLCBhMiwgYTMJIyB3ZSB3YW50IHRvIGtlZXAgdGhl IE1TQiBieXRlcwotI2VuZGlmCi0jaWYgX0JZVEVfT1JERVIgPT0gX0xJVFRMRV9FTkRJQU4KLQlS RUdfU0xMVglhMiwgYTIsIGEzCSMgd2Ugd2FudCB0byBrZWVwIHRoZSBMU0IgYnl0ZXMKLSNlbmRp ZgotCW5vcgkJYTIsIHplcm8sIGEyCSMgY29tcGxlbWVudCB0aGUgbWFzawotCVJFR19MCQl2MCwg LVNaUkVHKGEwKQkjIGxvYWQgdGhlIHdvcmQgdG8gcGFydGlhbGx5IGNsZWFyCi0JYW5kCQl2MCwg djAsIGEyCSMgY2xlYXIgdGhlIGJ5dGVzCi0JUkVHX1MJCXYwLCAtU1pSRUcoYTApCSMgc3RvcmUg aXQgYmFjawotI2VuZGlmCiAxOgogCWFuZAkJdjAsIGExLCBTWlJFRy0xCSMgY29tcHV0ZSBudW1i ZXIgb2Ygd29yZHMgbGVmdAogCVBUUl9TVUJVCWEzLCBhMSwgdjAK --00163630fe5544b6a5049cd8662e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin7%2Bf5v6fBX-TeMt=BxrH_3r1Qb_Y_y=HJ08Z=K>