Date: Wed, 18 Aug 2010 14:43:19 +0400 From: pluknet <pluknet@gmail.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: LOR on nfs: vfs_vnops.c:301 kern_descrip.c:1580 Message-ID: <AANLkTimXxF0US60NsbOV_HvRrib7SJWmrLqpEpznPTxB@mail.gmail.com> In-Reply-To: <AANLkTimyk0ZUnHpxxJuJtTya2U3npj_5Bm8brmwHfzr3@mail.gmail.com> References: <AANLkTimJ=d06D2z24QyRQ98zEa1Pemk4=vkNGLNiX90N@mail.gmail.com> <AANLkTi=22WWy8Z5VWqri1p70iRzyocD9bWvNHwJavZ%2Bj@mail.gmail.com> <20100816185456.GU2396@deviant.kiev.zoral.com.ua> <AANLkTimfZ=UCiX9eo9XCwcROwViFCxJoB-rD1JxdAt2B@mail.gmail.com> <20100817160445.GO2396@deviant.kiev.zoral.com.ua> <AANLkTimyk0ZUnHpxxJuJtTya2U3npj_5Bm8brmwHfzr3@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015175cb21edccb15048e16bb7b Content-Type: text/plain; charset=ISO-8859-1 On 18 August 2010 12:07, pluknet <pluknet@gmail.com> wrote: > On 17 August 2010 20:04, Kostik Belousov <kostikbel@gmail.com> wrote: > >> >> Also please take a note of the John' suggestion to use the taskqueue. > > I decided to go this road. Thank you both. > Now I do nfs buildkernel survive and prepare some benchmark results. > So, I modified the patch to defer proc_create() with taskqueue(9). Below is `time make -j5 buildkernel WITHOUT_MODULES=yes` perf. evaluation. Done on 4-way CPU on clean /usr/obj with /usr/src & /usr/obj both nfs-mounted over 1Gbit LAN. clean old 1137.985u 239.411s 7:42.15 298.0% 6538+2133k 87+43388io 226pf+0w clean new 1134.755u 240.032s 7:41.25 298.0% 6553+2133k 87+43367io 224pf+0w Patch needs polishing, though it generally works. Not sure if shep_chan (or whatever name it will get) needs locking. -- wbr, pluknet --0015175cb21edccb15048e16bb7b Content-Type: application/octet-stream; name="nfsiod_tq.diff" Content-Disposition: attachment; filename="nfsiod_tq.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gd01toqi0 SW5kZXg6IHN5cy9uZnNjbGllbnQvbmZzX3Zub3BzLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25mc2Ns aWVudC9uZnNfdm5vcHMuYwkocmV2aXNpb24gMjExMjc5KQorKysgc3lzL25mc2NsaWVudC9uZnNf dm5vcHMuYwkod29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsNyBAQAogI2luY2x1ZGUgPHN5cy9z dGF0Lmg+CiAjaW5jbHVkZSA8c3lzL3N5c2N0bC5oPgogI2luY2x1ZGUgPHN5cy9zaWduYWx2YXIu aD4KKyNpbmNsdWRlIDxzeXMvdGFza3F1ZXVlLmg+CiAKICNpbmNsdWRlIDx2bS92bS5oPgogI2lu Y2x1ZGUgPHZtL3ZtX29iamVjdC5oPgpAQCAtMjEyLDYgKzIxMyw3IEBACiAgKiBHbG9iYWwgdmFy aWFibGVzCiAgKi8KIHN0cnVjdCBtdHggCW5mc19pb2RfbXR4Oworc3RydWN0IHRhc2sJbmZzX25m c2lvZG5ld190YXNrOwogZW51bSBuZnNpb2Rfc3RhdGUgbmZzX2lvZHdhbnRbTkZTX01BWEFTWU5D REFFTU9OXTsKIHN0cnVjdCBuZnNtb3VudCAqbmZzX2lvZG1vdW50W05GU19NQVhBU1lOQ0RBRU1P Tl07CiBpbnQJCSBuZnNfbnVtYXN5bmMgPSAwOwpJbmRleDogc3lzL25mc2NsaWVudC9uZnNfc3Vi cy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIHN5cy9uZnNjbGllbnQvbmZzX3N1YnMuYwkocmV2aXNpb24gMjEx Mjc5KQorKysgc3lzL25mc2NsaWVudC9uZnNfc3Vicy5jCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2 ICs1OSw3IEBACiAjaW5jbHVkZSA8c3lzL3N5c2VudC5oPgogI2luY2x1ZGUgPHN5cy9zeXNjYWxs Lmg+CiAjaW5jbHVkZSA8c3lzL3N5c3Byb3RvLmg+CisjaW5jbHVkZSA8c3lzL3Rhc2txdWV1ZS5o PgogCiAjaW5jbHVkZSA8dm0vdm0uaD4KICNpbmNsdWRlIDx2bS92bV9vYmplY3QuaD4KQEAgLTM1 NCw2ICszNTUsNyBAQAogCSAqLwogCW10eF9pbml0KCZuZnNfaW9kX210eCwgIk5GUyBpb2QgbG9j ayIsIE5VTEwsIE1UWF9ERUYpOwogCW10eF9pbml0KCZuZnNfeGlkX210eCwgIk5GUyB4aWQgbG9j ayIsIE5VTEwsIE1UWF9ERUYpOworCVRBU0tfSU5JVCgmbmZzX25mc2lvZG5ld190YXNrLCAwLCBu ZnNfbmZzaW9kbmV3X3RxLCBOVUxMKTsKIAogCW5mc19wYnVmX2ZyZWVjbnQgPSBuc3didWYgLyAy ICsgMTsKIApJbmRleDogc3lzL25mc2NsaWVudC9uZnNfbmZzaW9kLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g c3lzL25mc2NsaWVudC9uZnNfbmZzaW9kLmMJKHJldmlzaW9uIDIxMTI3OSkKKysrIHN5cy9uZnNj bGllbnQvbmZzX25mc2lvZC5jCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw3IEBACiAjaW5j bHVkZSA8c3lzL2ZjbnRsLmg+CiAjaW5jbHVkZSA8c3lzL2xvY2tmLmg+CiAjaW5jbHVkZSA8c3lz L211dGV4Lmg+CisjaW5jbHVkZSA8c3lzL3Rhc2txdWV1ZS5oPgogCiAjaW5jbHVkZSA8bmV0aW5l dC9pbi5oPgogI2luY2x1ZGUgPG5ldGluZXQvdGNwLmg+CkBAIC03NSw2ICs3NiwxMiBAQAogCiBz dGF0aWMgdm9pZAluZnNzdmNfaW9kKHZvaWQgKik7CiAKK3N0cnVjdCBzaGVwaGVyZF9zdHIgewor CWludCAqc2hlcF9pbnN0OworCWludCBzaGVwX25pb2Q7CisJaW50IHNoZXBfZXJyb3I7Cit9IHNo ZXBfY2hhbjsKKwogc3RhdGljIGludCBuZnNfYXN5bmNkYWVtb25bTkZTX01BWEFTWU5DREFFTU9O XTsKIAogU1lTQ1RMX0RFQ0woX3Zmc19uZnMpOwpAQCAtMTU5LDEwICsxNjYsMTkgQEAKICAgICBz aXplb2YgKG5mc19pb2RtYXgpLCBzeXNjdGxfaW9kbWF4LCAiSVUiLAogICAgICJNYXggbnVtYmVy IG9mIG5mc2lvZCBrdGhyZWFkcyIpOwogCit2b2lkCituZnNfbmZzaW9kbmV3X3RxKF9fdW51c2Vk IHZvaWQgKmFyZywgaW50IHBlbmRpbmcpCit7CisKKwlzaGVwX2NoYW4uc2hlcF9lcnJvciA9IGtw cm9jX2NyZWF0ZShuZnNzdmNfaW9kLAorCSAgICBzaGVwX2NoYW4uc2hlcF9pbnN0LCBOVUxMLCBS RkhJR0hQSUQsIDAsICJuZnNpb2QgJWQiLAorCSAgICBzaGVwX2NoYW4uc2hlcF9uaW9kKTsKK30K KwogaW50CiBuZnNfbmZzaW9kbmV3KGludCBzZXRfaW9kd2FudCkKIHsKLQlpbnQgZXJyb3IsIGk7 CisJaW50IGk7CiAJaW50IG5ld2lvZDsKIAogCWlmIChuZnNfbnVtYXN5bmMgPj0gbmZzX2lvZG1h eCkKQEAgLTE3OCwxMSArMTk0LDEzIEBACiAJCXJldHVybiAoLTEpOwogCWlmIChzZXRfaW9kd2Fu dCA+IDApCiAJCW5mc19pb2R3YW50W2ldID0gTkZTSU9EX0NSRUFURURfRk9SX05GU19BU1lOQ0lP OworCWJ6ZXJvKCZzaGVwX2NoYW4sIHNpemVvZihzaGVwX2NoYW4pKTsKKwlzaGVwX2NoYW4uc2hl cF9pbnN0ID0gbmZzX2FzeW5jZGFlbW9uICsgaTsKKwlzaGVwX2NoYW4uc2hlcF9uaW9kID0gbmV3 aW9kOwogCW10eF91bmxvY2soJm5mc19pb2RfbXR4KTsKLQllcnJvciA9IGtwcm9jX2NyZWF0ZShu ZnNzdmNfaW9kLCBuZnNfYXN5bmNkYWVtb24gKyBpLCBOVUxMLCBSRkhJR0hQSUQsCi0JICAgIDAs ICJuZnNpb2QgJWQiLCBuZXdpb2QpOworCXRhc2txdWV1ZV9lbnF1ZXVlKHRhc2txdWV1ZV90aHJl YWQsICZuZnNfbmZzaW9kbmV3X3Rhc2spOwogCW10eF9sb2NrKCZuZnNfaW9kX210eCk7Ci0JaWYg KGVycm9yKSB7CisJaWYgKHNoZXBfY2hhbi5zaGVwX2Vycm9yKSB7CiAJCWlmIChzZXRfaW9kd2Fu dCA+IDApCiAJCQluZnNfaW9kd2FudFtpXSA9IE5GU0lPRF9OT1RfQVZBSUxBQkxFOwogCQlyZXR1 cm4gKC0xKTsKSW5kZXg6IHN5cy9uZnNjbGllbnQvbmZzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25m c2NsaWVudC9uZnMuaAkocmV2aXNpb24gMjExMjc5KQorKysgc3lzL25mc2NsaWVudC9uZnMuaAko d29ya2luZyBjb3B5KQpAQCAtMTI1LDYgKzEyNSw3IEBACiAKIGV4dGVybiBzdHJ1Y3QgbmZzc3Rh dHMgbmZzc3RhdHM7CiBleHRlcm4gc3RydWN0IG10eCBuZnNfaW9kX210eDsKK2V4dGVybiBzdHJ1 Y3QgdGFzayBuZnNfbmZzaW9kbmV3X3Rhc2s7CiAKIGV4dGVybiBpbnQgbmZzX251bWFzeW5jOwog ZXh0ZXJuIHVuc2lnbmVkIGludCBuZnNfaW9kbWF4OwpAQCAtMjUzLDYgKzI1NCw3IEBACiAJICAg IHN0cnVjdCB1Y3JlZCAqY3JlZCwgc3RydWN0IHRocmVhZCAqdGQpOwogaW50CW5mc19yZWFkZGly cnBjKHN0cnVjdCB2bm9kZSAqLCBzdHJ1Y3QgdWlvICosIHN0cnVjdCB1Y3JlZCAqKTsKIGludAlu ZnNfbmZzaW9kbmV3KGludCk7Cit2b2lkCW5mc19uZnNpb2RuZXdfdHEoX191bnVzZWQgdm9pZCAq LCBpbnQpOwogaW50CW5mc19hc3luY2lvKHN0cnVjdCBuZnNtb3VudCAqLCBzdHJ1Y3QgYnVmICos IHN0cnVjdCB1Y3JlZCAqLCBzdHJ1Y3QgdGhyZWFkICopOwogaW50CW5mc19kb2lvKHN0cnVjdCB2 bm9kZSAqLCBzdHJ1Y3QgYnVmICosIHN0cnVjdCB1Y3JlZCAqLCBzdHJ1Y3QgdGhyZWFkICopOwog dm9pZAluZnNfZG9pb19kaXJlY3R3cml0ZSAoc3RydWN0IGJ1ZiAqKTsK --0015175cb21edccb15048e16bb7b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimXxF0US60NsbOV_HvRrib7SJWmrLqpEpznPTxB>