Date: Tue, 31 May 2016 22:49:29 -0700 From: Mark Millard <markmi@dsl-only.net> To: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: 11.0 -r300944 build*KERNEL* via amd64-gcc fails for: .../dev/cxgb/ulp/tom/cxgb_listen.c:926:13: error: redundant redeclaration of 'tcp_dooptions'; cxgbe has an issue too Message-ID: <086B90E6-2E0C-4AA9-B429-523685EF1459@dsl-only.net> In-Reply-To: <AE72AC5F-7696-4C69-AD5A-2A99563CE75A@dsl-only.net> References: <1885ED2D-29CB-47EF-B746-7CAD52E91605@dsl-only.net> <AE72AC5F-7696-4C69-AD5A-2A99563CE75A@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-May-31, at 10:31 PM, Mark Millard <markmi at dsl-only.net> =
wrote:
> [I'm too used to typing "buildworld": The subject line should have =
referenced buildkernel and this resend does.]
>=20
> On 2016-May-31, at 10:21 PM, Mark Millard <markmi at dsl-only.net> =
wrote:
>>=20
>>> --- all_subdir_cxgb ---
>>> =
/usr/src/sys/modules/cxgb/tom/../../../dev/cxgb/ulp/tom/cxgb_listen.c:926:=
13: error: redundant redeclaration of 'tcp_dooptions' =
[-Werror=3Dredundant-decls]
>>> extern void tcp_dooptions(struct tcpopt *, u_char *, int, int);
>>> ^
>>> In file included from =
/usr/src/sys/modules/cxgb/tom/../../../dev/cxgb/ulp/tom/cxgb_listen.c:49:0=
:
>>> /usr/src/sys/netinet/tcp_var.h:769:7: note: previous declaration of =
'tcp_dooptions' was here
>>> void tcp_dooptions(struct tcpopt *, u_char *, int, int);
>>> ^
>> . . .
>> --- all_subdir_cxgb ---
>>> cc1: all warnings being treated as errors
>>> *** [cxgb_listen.o] Error code 1
>>=20
>>=20
>> I got this while experimenting with WITH_META_MODE=3Dyes for an =
external toolchain.
>>=20
>>=20
>> src.conf details:
>> (Yes it has some redundancies.)
>>=20
>> TO_TYPE=3Damd64
>> TOOLS_TO_TYPE=3Dx86_64
>> VERSION_CONTEXT=3D11.0
>> #
>> KERNCONF=3DGENERIC-NODEBUG
>> TARGET=3D${TO_TYPE}
>> .if ${.MAKE.LEVEL} =3D=3D 0
>> TARGET_ARCH=3D${TO_TYPE}
>> .export TARGET_ARCH
>> .endif
>> #
>> WITHOUT_CROSS_COMPILER=3D
>> WITHOUT_SYSTEM_COMPILER=3D
>> #
>> WITH_LIBCPLUSPLUS=3D
>> WITHOUT_BINUTILS_BOOTSTRAP=3D
>> WITHOUT_CLANG_BOOTSTRAP=3D
>> WITH_CLANG=3D
>> WITH_CLANG_IS_CC=3D
>> WITH_CLANG_FULL=3D
>> WITH_CLANG_EXTRAS=3D
>> WITH_LLDB=3D
>> #PORTS_MODULES=3Demulators/virtualbox-ose-additions
>> #
>> #WITH_BOOT=3D for amd64-xtoolschain-gcc/amd64-gcc gets...=20
>> # --- all_subdir_sys ---
>> # -994 bytes available
>> # *** [boot2] Error code 1
>> WITHOUT_BOOT=3D
>> WITH_LIB32=3D
>> #
>> WITHOUT_ELFTOOLCHAIN_BOOTSTRAP=3D
>> WITHOUT_GCC_BOOTSTRAP=3D
>> WITHOUT_GCC=3D
>> WITHOUT_GCC_IS_CC=3D
>> WITHOUT_GNUCXX=3D
>> #
>> NO_WERROR=3D
>> #WERROR=3D
>> MALLOC_PRODUCTION=3D
>> #
>> WITH_DEBUG_FILES=3D
>> #
>> #
>> # For TO (so-called "cross") stages . . .
>> # So-called-cross via ${TO_TYPE}-xtoolchain-gcc/${TO_TYPE}-gcc. . .
>> # TOOLS_TO_TYPE based on ${TO_TYPE}-xtoolchain-gcc related binutils. =
. .
>> #
>> CROSS_TOOLCHAIN=3D${TO_TYPE}-gcc
>> X_COMPILER_TYPE=3Dgcc
>> CROSS_BINUTILS_PREFIX=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/
>> .if ${.MAKE.LEVEL} =3D=3D 0
>> =
XCC=3D/usr/local/bin/${TOOLS_TO_TYPE}-portbld-freebsd${VERSION_CONTEXT}-gc=
c
>> =
XCXX=3D/usr/local/bin/${TOOLS_TO_TYPE}-portbld-freebsd${VERSION_CONTEXT}-g=
++
>> =
XCPP=3D/usr/local/bin/${TOOLS_TO_TYPE}-portbld-freebsd${VERSION_CONTEXT}-c=
pp
>> .export XCC
>> .export XCXX
>> .export XCPP
>> XAS=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/as
>> XAR=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/ar
>> XLD=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/ld
>> XNM=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/nm
>> XOBJCOPY=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/objcopy
>> XOBJDUMP=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/objdump
>> XRANLIB=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/ranlib
>> XSIZE=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/size
>> #NO-SUCH: XSTRINGS=3D/usr/local/${TOOLS_TO_TYPE}-freebsd/bin/strings
>> XSTRINGS=3D/usr/local/bin/${TOOLS_TO_TYPE}-freebsd-strings
>> .export XAS
>> .export XAR
>> .export XLD
>> .export XNM
>> .export XOBJCOPY
>> .export XOBJDUMP
>> .export XRANLIB
>> .export XSIZE
>> .export XSTRINGS
>> .endif
>> #
>> #
>> # =46rom based on clang (via system). . .
>> #
>> .if ${.MAKE.LEVEL} =3D=3D 0
>> CC=3D/usr/bin/clang
>> CXX=3D/usr/bin/clang++
>> CPP=3D/usr/bin/clang-cpp
>> .export CC
>> .export CXX
>> .export CPP
>> .endif
>=20
>=20
> =3D=3D=3D
> Mark Millard
> markmi at dsl-only.net
If the offending declaration in cxgb_listen.c is commented out (or =
removed) there is a "next problem" but for cxgbe:
> --- all_subdir_cxgbe/tom ---
> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c: In =
function 'do_pass_accept_req':
> =
/usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:640:1: =
warning: inlining failed in call to 'release_synqe': call is unlikely =
and code size would grow [-Winline]
> release_synqe(struct synq_entry *synqe)
> ^
> =
/usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:1406:3: =
warning: called from here [-Winline]
> release_synqe(synqe); /* extra hold */
> ^
> =
/usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:640:1: =
warning: inlining failed in call to 'release_synqe': call is unlikely =
and code size would grow [-Winline]
> release_synqe(struct synq_entry *synqe)
> ^
> =
/usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:1411:2: =
warning: called from here [-Winline]
> release_synqe(synqe); /* extra hold */
> ^
. . .
> --- all_subdir_cxgbe/tom ---
> cc1: all warnings being treated as errors
> *** [t4_listen.o] Error code 1
It looks like this code area has not been tried under devel/amd64-gcc =
compiles.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209920 has the =
material for these.
=3D=3D=3D
Mark Millard
markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?086B90E6-2E0C-4AA9-B429-523685EF1459>